Repository navigation
Conversation
README: the app icon above the title
Excel 2010+ writes a conditional format into the extension list alone (x14:conditionalFormatting, formulas in xm:f, the format inline in x14:dxf) when its formula refers to another sheet, and some exporters write every rule that way. GridCraft read that list only for data-bar extensions and dropped these rules, so such sheets lost their highlighting. The cfRule parsing is shared (cf_rule), the dxf parsing too (read_dxf); a standalone x14 rule is read with its xm:sqref ranges and saved as an ordinary conditional format. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pick2510
force-pushed
the
fix/x14-conditional-formats
branch
from
October 22, 2026 13:00
f3dca9b to
1392304
Compare
Owner
Author
|
Superseded by storytold#2262 (same branch, opened upstream). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Excel 2010+ writes a conditional format into the extension list alone when the rule's formula refers to another sheet:
x14:conditionalFormatting, with formulas inxm:fand the format inline inx14:dxf. Some exporters write every rule that way. GridCraft read that list only for data-bar extensions and dropped these rules. In three grade sheets from a private corpus (not committed), the pink "repeat student" highlighting over a whole block of rows was missing.cf_rule(): thecfRuletype match is now shared between<conditionalFormatting>and the x14 list.styles::read_dxf(): dxf parsing is shared, and also reads an inlinex14:dxf.xm:sqrefranges, priority and stop-if-true. It is saved as an ordinary conditional format. A rule without a range is skipped with the existing warning.Tests (built in code)
crates/xlsx/src/tests/x14_cond_formats.rs:x14_only_rules_are_read: a cell-value rule (operator, formula, font and fill colours, priority) and an expression rule over two ranges are read, and a rule without a range is dropped.x14_only_rules_survive_saving: the same checks afterwrite_xlsxand a re-read.Both fail on
main, where no rules are read.CI
cargo xtask ci: fmt, clippy, assets, layers, wasm, parity and keytips pass, and every test passes except the pre-existingheader_autofit::table_filter_autofit_works_through_command_and_header_double_click. That test fails identically onmainon this machine with Carlito installed (see #1).🤖 Generated with Claude Code