Repository navigation
1.0.0 - #48
1.0.0#48jonathanong wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
|
@jonathanong is this dependant on crypto-utils/keygrip#14 (keygrip 2.0.0) ? |
yes |
Keygrip is 0.10+ anyways, so.. (Well, the current master is.) |
See crypto-utils/keygrip@71df3df#commitcomment-6552647 It can likely be made node 0.8, I just have to look into it. I just want them to release node 0.12 already! |
Yeah, but we are honestly looking at months still. |
Yea, that's what sucks :( If they did rel 0.12, I would be more willing to drop node 0.8 support for things is all :) |
|
I'm surprised people still use 0.8 - at this point it really isn't (that) more stable than 0.10, and npm is broken in it, etc. Aside from a couple obscure minor performance regressions. (/off-topic rant) |
|
There are certain private PaaS systems (not to name names) where the 0.10 on them is 0.10.1, which is extremely buggy, so there is no other choice. |
oh god |
it was also the release before Joyent turned off heartbeats, so it is vulnerable to heartbleed. |
cool :) just let it keep failing until i check out what it would take to make 0.8 work :) |
|
so aside from the keygrip stuff which can just easily disabled by checking whether the methods exist,
|
|
|
|
Looks like the error you posted is caused because at least one of the array elements you passed into |
|
Hmmm maybe crypto api changed then |
|
Maybe, haha. I plan to knock out the first todo tomorrow, perhaps I'll look into node.js 0.8 as well to determine if whatever the issue is can be made to work there or not. |
|
The current |
|
I'm sorry for asking, when do you plan to release v1.0.0? |
|
When the kinks are worked out. |
|
Waiting for 1.0.0~~~ |
|
Any progress? |
|
stop? @jonathanong |
|
@dougwilson what's the status on this? should i rebase? or did you have some ideas? |
|
@dougwilson any status updateS? |
7ff6e77 to
636ff79
Compare
basically hits all the 1.0.0 milestones
var cookies = require('Cookies')([options], [keys])thenreq.cookies = res.cookies = cookies(req, res).app.use(require('cookies')([keys])).get()and.set()now only set raw cookies.sign()and.unsign()for signed cookies, with.encodedto optionally base64 encode as well. maybe a better name for.unsign().encode()and.decode()for base64 encoded cookies.encrypt()and.decrypt()for encrypted cookies.clear()to clear a cookie quicklyi found juggling all the options a little weird since you could have combos.
thus i opted to have each of them be a pair of methods.
Option changes:
overwritedefaults totrueTo do:
Maybe:
To test, you need to install
keygripmaster andnpm linkit since i haven't publishedv2yetplease test and give me feedback before i push v1
/cc @dougwilson @Fishrock123