req.socket might be null #42

Activity

1. dougwilson commented on Jul 4, 2022

   

   dougwilson

   on Jul 4, 2022

   Contributor

   More actions

   Thanks for reporting, @Gerhut ! I do indeed see the Node.js docs have updated to note that req.socket is no longer guaranteed to be there, and that there is a code path within Node.js itself that now unsets it. I will get a patch out for this module to account for this new behavior.
2. dougwilson

   self-assigned this

   on Jul 4, 2022
3. dougwilson commented on Jul 13, 2022

   

   dougwilson

   on Jul 13, 2022

   Contributor

   More actions

   Sorry for the delay on this. It seems very convoluted on when exactly Node.js will make req.socket null. I see that there is a guard against that in req.destroy(), though not a lot of other methods on req. I believe we can just call req.destroy() anyway, just verifying that will behave as expected across the supported Node.js versions of this module before landing, as it would be the simplest solution 👍
4. blazzy commented on Jun 21, 2023

   

   blazzy

   on Jun 21, 2023

   Last edited by blazzy

   More actions

   @dougwilson Any luck with this? I'm running into an occasional error where req.socket is null and req.socket.destroy ends up blowing up.
   Undici in particular is clearing out the socket when we stream a request through it and the connection is suddenly killed.
5. wesleytodd commented on Sep 1, 2024

   

   wesleytodd

   on Sep 1, 2024

   Member

   More actions

   Just opened #57 with a fix for this. Planning on releasing it in the current major and then pulling it into express asap. Moving any discussion over there now.
6. wesleytodd

   closed this as completedon Sep 1, 2024