Repository navigation
refactor: replace methods dependency with standard library - #127
Merged
Merged
Conversation
UlisesGascon
approved these changes
Oct 22, 2024
blakeembrey
approved these changes
Oct 22, 2024
Signed-off-by: Jon Koops <jonkoops@gmail.com>
jonkoops
force-pushed
the
replace-methods
branch
from
October 23, 2024 08:17
f9b8d77 to
2f5aa88
Compare
wesleytodd
approved these changes
Oct 23, 2024
wesleytodd
left a comment
wesleytodd
left a comment
Member
There was a problem hiding this comment.
And another one bites the dust!
UlisesGascon
changed the title
methods dependency with standard librarymethods dependency with standard library
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
methodsdependency with calls to the standard library of Node.js. Sincemethodsis mostly a polyfill forrequire('node:http').METHODSin older versions of Node.js that are no longer supported this can be removed.