Skip to content

team/tidb: A Vote for nomination of expxiaoli as the TiDB reviewer - #825

Merged
bb7133 merged 6 commits into
pingcap:masterfrom
bb7133:nominate-expxiaoli-tidb-reviewer
Aug 13, 2026
Merged

bb7133 merged 6 commits into
pingcap:masterfrom
bb7133:nominate-expxiaoli-tidb-reviewer

Conversation

@bb7133

@bb7133 bb7133 commented Aug 7, 2026

Copy link
Copy Markdown
Member

(votes/0825-expxiaoli-as-tidb-reviewer.md):


@expxiaoli has contributed to pingcap/tidb in several important areas, especially DDL stability, add-index resource safety, privilege model correctness, and upgrade-path robustness.

The following lists the details of @expxiaoli's TiDB contributions as of August 7, 2026:

Representative work includes:

  • Add-index resource safety: auto pause add-index on TiKV disk full #69350, #69181, and TiKV space precheck for DXF add-index #68490
  • Privilege model correctness: canonicalize db/table names for table-scope GRANT and REVOKE #67487 with release backports #68456, #68547, and hardening parseBinaryParams against malformed input #68917
  • DDL correctness and safety: partition-column type change whitelist #67635, prohibiting indexed generated column type changes #67814, using real start ts for recover table snapshot #68229, and fixing ALTER TABLE NOCACHE metadata cleanup #67109
  • Upgrade-path robustness: initializing / tolerating the masking policy table during upgrade #69763, #69531

He has also reviewed TiDB changes in closely related areas, including DDL / add-index improvements, masking policy privileges, and server protocol limits, such as #69706, #69425, #69107, and #70231.

I (@bb7133) hereby nominate @expxiaoli as TiDB Reviewer and call for a vote.

@bb7133
bb7133 requested review from a team and zhangyangyu as code owners August 7, 2026 07:46
@ti-chi-bot
ti-chi-bot Bot requested a review from qiuyesuifeng August 7, 2026 07:46
@ti-chi-bot ti-chi-bot Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 7, 2026
@bb7133 bb7133 changed the title community: nominate expxiaoli as TiDB reviewer team/tidb: A Vote for nomination of expxiaoli as the TiDB reviewer Aug 7, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

@AilinKid: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot

ti-chi-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

@D3Hunter: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot

ti-chi-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

@YangKeao: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot

ti-chi-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AilinKid, D3Hunter, disksing, YangKeao
Once this PR has been reviewed and has the lgtm label, please assign zhangyangyu for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the lgtm label Aug 11, 2026
@bb7133

bb7133 commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

Thanks, voters! I'll update the result and get this merged.

@ti-chi-bot ti-chi-bot Bot removed the lgtm label Aug 13, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-11 03:28:04.189678384 +0000 UTC m=+3103470.225773440: ☑️ agreed by disksing.
  • 2026-08-13 06:14:01.418937991 +0000 UTC m=+3286227.455033047: ✖️🔁 reset by bb7133.

@ti-chi-bot

ti-chi-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@bb7133
bb7133 merged commit 88a9885 into pingcap:master Aug 13, 2026
2 checks passed
@bb7133
bb7133 deleted the nominate-expxiaoli-tidb-reviewer branch August 13, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants