Skip to content

copr: add max_keys_read coprocessor Request - #1447

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
Tema:max-keys-read
Apr 10, 2026
Merged

ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
Tema:max-keys-read

Conversation

@Tema

@Tema Tema commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

@ti-chi-bot ti-chi-bot Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 1, 2026
@pingcap-cla-assistant

pingcap-cla-assistant Bot commented Apr 1, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Signed-off-by: artem_danilov <artem.danilov@airbnb.com>
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 7, 2026
@Tema

Tema commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

@tiancaiamao could you please /ok-to-test as I don't see tests are running for this PR

@terry1purcell

Copy link
Copy Markdown

/ok-to-test

@ti-chi-bot ti-chi-bot Bot added the ok-to-test Indicates a PR is ready to be tested. label Apr 7, 2026
@Tema Tema mentioned this pull request Apr 8, 2026
9 tasks
@ti-chi-bot

ti-chi-bot Bot commented Apr 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 9, 2026
@ti-chi-bot

ti-chi-bot Bot commented Apr 9, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-04-07 07:17:57.223944276 +0000 UTC m=+854282.429304343: ☑️ agreed by tiancaiamao.
  • 2026-04-09 02:03:41.918818726 +0000 UTC m=+1008227.124178782: ☑️ agreed by cfzjywxk.

@wuhuizuo

Copy link
Copy Markdown
Contributor

/retest

@ti-chi-bot
ti-chi-bot Bot merged commit bb32227 into pingcap:master Apr 10, 2026
5 checks passed
ti-chi-bot Bot pushed a commit that referenced this pull request Jul 16, 2026
* copr: add max_keys_read coprocessor Request (#1447)

Signed-off-by: artem_danilov <artem.danilov@airbnb.com>
(cherry picked from commit bb32227)
Signed-off-by: JmPotato <github@ipotato.me>

* proto: add paging_size_bytes to coprocessor.Request (#1448)

Add a new uint64 field `paging_size_bytes` (field 17) to the
coprocessor Request message. When set, TiKV will stop scanning
when accumulated scanned bytes reach this limit, enabling
byte-budget paging for finer-grained Resource Control.

Note: rebased onto upstream master where field 16 is now taken
by max_keys_read (#1450), so paging_size_bytes was bumped from
field 16 to field 17.

Signed-off-by: JmPotato <github@ipotato.me>
(cherry picked from commit a15c348)
Signed-off-by: JmPotato <github@ipotato.me>

---------

Signed-off-by: artem_danilov <artem.danilov@airbnb.com>
Signed-off-by: JmPotato <github@ipotato.me>
Co-authored-by: Artem Danilov <tema.danilov@gmail.com>
ti-chi-bot Bot pushed a commit that referenced this pull request Oct 15, 2026
(cherry picked from commit bb32227)

Signed-off-by: artem_danilov <artem.danilov@airbnb.com>
Co-authored-by: tiancaiamao <tiancaiamao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ok-to-test Indicates a PR is ready to be tested. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants