Repository navigation
parser: add config variable to control max display length - #949
Merged
Merged
Conversation
Signed-off-by: AilinKid <314806019@qq.com>
Codecov Report
@@ Coverage Diff @@
## master #949 +/- ##
==========================================
- Coverage 78.39% 78.37% -0.02%
==========================================
Files 40 40
Lines 14933 14936 +3
==========================================
Hits 11706 11706
- Misses 2536 2538 +2
- Partials 691 692 +1 |
Contributor
Author
|
TiDB #18787 is the pr to fix the integration test (removing the mysql.decimal field), but it's parser is including max-display-length-warning commit which I filed serveral days ago, which will cause test check failed in TiDB Repo. So this pr is to correct the TiDB test check behavior. |
crazycs520
reviewed
Jul 29, 2020
| x := types.NewFieldType($1.(byte)) | ||
| x.Flen = $2.(int) | ||
| if $2.(int) != types.UnspecifiedLength { | ||
| if $2.(int) != types.UnspecifiedLength && types.TiDBStrictIntegerDisplayWidth { |
Contributor
Author
There was a problem hiding this comment.
this my previous pr, it will parse int(10) as warnings, it should be under the control of this variable
ti-srebot
approved these changes
Jul 29, 2020
tangenta
approved these changes
Jul 29, 2020
vitthalaa
pushed a commit
to vitthalaa/parser
that referenced
this pull request
Oct 14, 2020
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AilinKid 314806019@qq.com
What problem does this PR solve?
Since TiDB and Parser has implemented much tests with int(11), bigint(20) and so on, it better to add the varible as a transition from
supportedtodeprecated.The benefit is that we don't have to change all the tests implemented with int(11) ,bigint(20) and so on, even some tests in the other repo, like TiDB-Test, Parser...
Also
TiDB #18787 is the pr to fix the integration test (removing the mysql.decimal field), but it's parser is including max-display-length-warning commit which I filed serveral days ago, which will cause test check failed in TiDB Repo.
So this pr is to correct the TiDB test check behavior.
What is changed and how it works?
Add the config variable in parser drived by TiDB config.
Check List
Tests