Repository navigation
plan replayer can't handle views correctly if it's dumped and loaded by different users #59653
Description
Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
mysql -h 127.0.0.1 -P 4000 -u rootcreate user 'test1';
grant all privileges on test.* to 'test1';mysql -h 127.0.0.1 -P 4000 -u test1use test;
create table t(a int, b int);
create view v1 as select a from t;
plan replayer dump explain select * from v1;Start a new tidb cluster.
mysql -h 127.0.0.1 -P 4000 -u rootplan replayer load 'xxx';
explain select * from v1;2. What did you expect to see? (Required)
The execution plan is displayed.
3. What did you see instead (Required)
> explain select * from v1;
ERROR 1356 (HY000): View 'test.v1' references invalid table(s) or column(s) or function(s) or definer/invoker of view lack rights to use them
4. What is your TiDB version? (Required)
master (v9.0.0)
Activity
[-]plan replayer can't handle views well it's dumped and loaded by different users[/-][+]plan replayer can't handle views correctly if it's dumped and loaded by different users[/+]time-and-fate commentedon Feb 19, 2025
Root cause
If you look at the definition of the view in the plan replayer, you'll find:
Notice the
DEFINER=`test1`@`%` SQL SECURITY DEFINERhere.By default, if it's not specified in the
create viewstatement, theDEFINERwould be the current user, and theSQL SECURITYwould beDEFINER. This means no matter who is querying this view, it's using the privilege of theDEFINER.When we load the plan replayer, usually we'll use the
rootuser. Apparently theDEFINER, i.e. thetest1user, doesn't have the privilege to query thetest.ttable in the new environment.Workaround
If you meet the error when loading the plan replayer, you can drop the views, remove the
DEFINERclause from thecreate viewstatements, and manually create the views again.Possible fix
DEFINERandSQL SECURITYclauses for view definitions when dumpling the plan replayer.SQL SECURITY INVOKERfor view definitions when dumpling the plan replayer.ghazalfamilyusa commentedon Feb 20, 2025
I vote for #1 since most likely replayer is not used to debug issues related to privileges. Also, I suggest adding description of this behaviour to the docs.