Repository navigation
Shenli/fix beego - #181
Merged
Merged
Shenli/fix beego#181
Conversation
shenli
commented
Sep 17, 2015
shenli
commented
Member
- Support alias table name in update multiple table
- Support LIKE BINARY
Fix bug found in beego/orm
Support "LIKE BINARY expr"
Member
There was a problem hiding this comment.
you can use switch type
switch x := pattern.(type)
case string:
case []byte:
default:
Member
Author
|
PTAL |
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* README, docker: add quick start Signed-off-by: Neil Shen <overvenus@gmail.com> * cmd: disable some TiDB log Signed-off-by: Neil Shen <overvenus@gmail.com> * docker: build go-ycsb automatically Signed-off-by: Neil Shen <overvenus@gmail.com> * cmd: add TODO about TiDB logs Signed-off-by: Neil Shen <overvenus@gmail.com>
nolouch
pushed a commit
to tidblabs/tidb
that referenced
this pull request
Jan 6, 2023
* add placement in sem Signed-off-by: ystaticy <y_static_y@sina.com>
crazycs520
pushed a commit
that referenced
this pull request
Oct 30, 2025
ngaut
added a commit
to ngaut/tidb
that referenced
this pull request
Aug 2, 2026
…ion point
Go's overflow message ends ` in '<expr>'`. It is built AT THE SIGNATURE
-- builtin_arithmetic.go writes fmt.Sprintf("(%s + %s)", args[0].String(),
args[1].String()) -- so the text is each RESOLVED argument's own String(),
not the statement's source.
Two pieces of plumbing are absent here, and either one alone makes a
hand-written approximation diverge, so this reports the seam rather than
half-building it:
* a column renders fully qualified, test.t.a. The rewritten
tidb_expr::Expr::Column holds the path AS WRITTEN; the resolved
db.table.column lives in the executor's FromScope and the Columns
trait the evaluator holds cannot be asked for it. The qualifier is
not unformatted at the raising frame -- it is not there.
* a literal renders as Go's formatting of the VALUE, not the source
text: 1e308 comes back as 1e+308. So a restore diverges even for a
constant-only expression, the case that looks trivially portable.
pingcap#74's generated-column expr_text is NOT reusable: restored with
WITHOUT_SCHEMA_NAME | WITHOUT_TABLE_NAME | NAME_BACK_QUOTES it produces
(`a` + 1), stripping exactly the qualifiers this message needs and
back-quoting the names it leaves bare.
Insertion point recorded in the test doc: tidb_expr::eval_in's
Expr::Binary(op, l, r) arm, which already holds Go's s.args.
The test pins today's class-and-code answer with the target text beside
it, so the divergence is measured rather than forgotten.
dbsid
pushed a commit
that referenced
this pull request
Aug 24, 2026
…#181 divergence Captured live from Go nightly on this exact fixture: SELECT 9223372036854775807 + 1 -> BIGINT value is out of range in '(9223372036854775807 + 1)' SELECT a + b FROM t (runtime columns) -> BIGINT value is out of range in '(ovx.t.a + ovx.t.b)' The folded-constant arm of this tier already matches the first form; the test now pins it instead of expecting the bare class message. The runtime-column arm still reports only the class - divergence #181 remains open there, and the test says so explicitly per case rather than asserting one stale shape for all four statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.