Skip to content

ddl: support specifying expr rand() as column default value - #32608

Merged
ti-chi-bot merged 32 commits into
pingcap:masterfrom
CbcWestwolf:column_default_expr
Apr 7, 2022
Merged

ddl: support specifying expr rand() as column default value#32608
ti-chi-bot merged 32 commits into
pingcap:masterfrom
CbcWestwolf:column_default_expr

Conversation

@CbcWestwolf

@CbcWestwolf CbcWestwolf commented Feb 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: close #10377

Problem Summary:

Now TiDB only supports nextVal(), now()/current_timestamp() and literal value as a column's default value.

What is changed and how it works?

Implement rand() as a default value.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot

ti-chi-bot commented Feb 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 24, 2022
@sre-bot

sre-bot commented Feb 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/299bf2e2d88be752340ea135252886c656e29383

@CbcWestwolf

CbcWestwolf commented Feb 28, 2022

Copy link
Copy Markdown
Member Author

/run-mysql-test

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 5, 2022
@CbcWestwolf
CbcWestwolf force-pushed the column_default_expr branch from bfb05d2 to 1720c3e Compare March 29, 2022 12:55
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2022
@CbcWestwolf
CbcWestwolf marked this pull request as ready for review March 29, 2022 13:09
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2022
@CbcWestwolf CbcWestwolf changed the title ddl: supporting create table or alter column with default expression ddl: supporting create table or alter column with default rand() Mar 29, 2022
@CbcWestwolf

CbcWestwolf commented Mar 31, 2022

Copy link
Copy Markdown
Member Author

/cc tangenta xiongjiwei

@xiongjiwei

xiongjiwei commented Mar 31, 2022

Copy link
Copy Markdown
Contributor

please fix the test

xiongjiwei
xiongjiwei reviewed Mar 31, 2022
View reviewed changes
Comment thread ddl/ddl_api.go Resolved
Comment thread parser/parser.y Resolved
Comment thread ddl/ddl_api.go Resolved
Comment thread ddl/db_integration_test.go Resolved
Comment thread parser/parser.y Resolved
xiongjiwei
xiongjiwei reviewed Mar 31, 2022
View reviewed changes

@xiongjiwei xiongjiwei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add some tests in parser

Comment thread parser/parser.y Resolved
Comment thread ddl/db_integration_test.go Resolved
@tangenta tangenta changed the title ddl: supporting create table or alter column with default rand() ddl: support specifying expr rand() as column default value Apr 6, 2022
@CbcWestwolf
CbcWestwolf requested a review from tangenta April 6, 2022 08:31
@CbcWestwolf
CbcWestwolf force-pushed the column_default_expr branch from 5bc2406 to f9d0aae Compare April 6, 2022 08:44
tangenta
tangenta reviewed Apr 6, 2022
View reviewed changes
Comment thread ddl/db_integration_test.go Resolved
tangenta
tangenta reviewed Apr 7, 2022
View reviewed changes
Comment thread ddl/ddl_api.go Resolved
@tangenta

tangenta commented Apr 7, 2022

Copy link
Copy Markdown
Contributor

Rest LGTM

@CbcWestwolf @tangenta
Update ddl/ddl_api.go
a289bdb 
Co-authored-by: tangenta <tangenta@126.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 7, 2022
@tangenta

tangenta commented Apr 7, 2022

Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot

ti-chi-bot commented Apr 7, 2022

Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: a289bdb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2022
@ti-chi-bot

ti-chi-bot commented Apr 7, 2022

Copy link
Copy Markdown
Member

@CbcWestwolf: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
ti-chi-bot merged commit a936646 into pingcap:master Apr 7, 2022
@CbcWestwolf
CbcWestwolf deleted the column_default_expr branch April 7, 2022 08:21
@dveeden dveeden mentioned this pull request Jul 21, 2023
Closed
@dveeden dveeden mentioned this pull request Dec 13, 2024
Merged
2 of 16 tasks
This was referenced Jan 6, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tangenta tangenta tangenta approved these changes
+1 more reviewer
@xiongjiwei xiongjiwei xiongjiwei approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incompatible with MySQL 8.0 about create table with default expression

5 participants

@CbcWestwolf @ti-chi-bot @sre-bot @xiongjiwei @tangenta