Skip to content

parser: Update ServerVersion to 8.0.11 - #42560

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
dveeden:mysql8
Apr 25, 2023
Merged

parser: Update ServerVersion to 8.0.11#42560
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
dveeden:mysql8

Conversation

@dveeden

@dveeden dveeden commented Mar 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #7968

Problem Summary:

Note that 8.0.11 was chosen as it is the first G.A. version of MySQL 8.0. More features were added in later point releases.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

The MySQL version number reported by TiDB was updated to 8.0.11

@ti-chi-bot

ti-chi-bot commented Mar 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • mjonss

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot

ti-chi-bot commented Mar 24, 2023

Copy link
Copy Markdown
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 24, 2023
@dveeden

dveeden commented Mar 24, 2023

Copy link
Copy Markdown
Contributor Author

/test all

@dveeden
dveeden marked this pull request as ready for review March 24, 2023 12:27
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2023
@dveeden
dveeden marked this pull request as draft March 24, 2023 12:28
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2023
@dveeden
dveeden marked this pull request as ready for review March 24, 2023 12:28
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2023
@dveeden
dveeden marked this pull request as draft March 24, 2023 12:58
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2023
@dveeden
dveeden marked this pull request as ready for review April 4, 2023 10:50
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2023
@dveeden
dveeden requested review from bb7133 and mjonss April 4, 2023 10:50
@dveeden

dveeden commented Apr 4, 2023

Copy link
Copy Markdown
Contributor Author

/retest

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 4, 2023
mjonss
mjonss approved these changes Apr 4, 2023
View reviewed changes

@mjonss mjonss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 4, 2023
@dveeden
dveeden marked this pull request as draft April 5, 2023 05:31
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2023
@dveeden
dveeden marked this pull request as ready for review April 24, 2023 10:27
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2023
@dveeden

dveeden commented Apr 25, 2023

Copy link
Copy Markdown
Contributor Author

/merge

@ti-chi-bot

ti-chi-bot Bot commented Apr 25, 2023

Copy link
Copy Markdown

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 68f8fb4

@ti-chi-bot ti-chi-bot Bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2023
@ti-chi-bot
ti-chi-bot Bot merged commit 0d37102 into pingcap:master Apr 25, 2023
@dveeden dveeden mentioned this pull request Apr 26, 2023
Merged
1 of 12 tasks
dveeden added a commit that referenced this pull request Jun 16, 2023
@dveeden
Revert "parser: Update ServerVersion to 8.0.11 (#42560)"
cf3c46a 
This reverts commit 0d37102.
@dveeden dveeden mentioned this pull request Jun 16, 2023
Merged
@dveeden dveeden mentioned this pull request Aug 16, 2023
Merged
3 of 12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjonss mjonss mjonss approved these changes
@bb7133 bb7133 Awaiting requested review from bb7133
+1 more reviewer
@hawkingrei hawkingrei hawkingrei approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dveeden @ti-chi-bot @hawkingrei @mjonss