Skip to content

doc: add grouping sets doc - #46906

Merged
AilinKid merged 2 commits into
pingcap:masterfrom
AilinKid:grouping-sets
Jan 8, 2024
Merged

AilinKid merged 2 commits into
pingcap:masterfrom
AilinKid:grouping-sets

Conversation

@AilinKid

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #42631

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

doc: add grouping sets doc

Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 12, 2023
@tiprow

tiprow Bot commented Sep 12, 2023

Copy link
Copy Markdown

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elsa0520 elsa0520 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 13, 2023
.
Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot

ti-chi-bot Bot commented Jan 8, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsa0520, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [elsa0520,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 8, 2024
@ti-chi-bot

ti-chi-bot Bot commented Jan 8, 2024

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2023-09-13 04:41:43.269005374 +0000 UTC m=+60469.236593410: ☑️ agreed by elsa0520.
  • 2024-01-08 09:58:21.786741613 +0000 UTC m=+264491.370995295: ☑️ agreed by hawkingrei.

@AilinKid
AilinKid merged commit 784fb19 into pingcap:master Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Underlying Grouping Sets

3 participants