Skip to content

statistics: reduce allocation of types.Context (#52615) - #52963

Merged
ti-chi-bot[bot] merged 14 commits into
pingcap:release-8.1from
ti-chi-bot:cherry-pick-52615-to-release-8.1
Apr 29, 2024
Merged

ti-chi-bot[bot] merged 14 commits into
pingcap:release-8.1from
ti-chi-bot:cherry-pick-52615-to-release-8.1

Conversation

@ti-chi-bot

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #52615

What problem does this PR solve?

Issue Number: close #52342

Problem Summary:

We still have #52429, but we can reduce the allocations first.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Apr 28, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 28, 2024
@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 28, 2024
@codecov

codecov Bot commented Apr 28, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-8.1@fafdbbc). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #52963   +/-   ##
================================================
  Coverage               ?   71.1343%           
================================================
  Files                  ?       1463           
  Lines                  ?     420392           
  Branches               ?          0           
================================================
  Hits                   ?     299043           
  Misses                 ?     100905           
  Partials               ?      20444           
Flag Coverage Δ
unit 71.1343% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 40.9483% <0.0000%> (?)

@ti-chi-bot

ti-chi-bot Bot commented Apr 29, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: time-and-fate, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [time-and-fate,winoros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the lgtm label Apr 29, 2024
@ti-chi-bot ti-chi-bot Bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 29, 2024
@ti-chi-bot

ti-chi-bot Bot commented Apr 29, 2024

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2024-04-28 19:44:34.051782415 +0000 UTC m=+213627.808917991: ☑️ agreed by winoros.
  • 2024-04-29 04:02:02.405098975 +0000 UTC m=+243476.162234549: ☑️ agreed by time-and-fate.

@winoros

winoros commented Apr 29, 2024

Copy link
Copy Markdown
Member

/retest

@ti-chi-bot
ti-chi-bot Bot merged commit f37e5f3 into pingcap:release-8.1 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants