planner: cache mpp info to avoid frequent grpc calling by xzhangxian1008 · Pull Request #65694 · pingcap/tidb

xzhangxian1008 · 2026-01-21T08:04:16Z

What problem does this PR solve?

Issue Number: close #65701

Problem Summary:

What changed and how does it work?

We define a new struct called MPPInfoManager and set a global variable GlobalMPPInfoManager with MPPInfoManager type. mpp info are all cached in this variable. In getTiFlashServerMinLogicalCores, we will check the cache first then call grpc for uncached tiflash stores. When we get a failed tiflash store in filterAliveStoresHelper, we will remove it's cache.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Summary by CodeRabbit

Refactor
- TiFlash query paths now use a cached per-node CPU metric to reduce repeated hardware queries and improve planner efficiency.
- Cluster server info retrieval now aggregates responses into a single result set while skipping failed nodes for more stable diagnostics and fewer partial failures.
Tests
- Added tests covering the node info caching and manager behavior to ensure correct refresh and failure handling.

tiprow · 2026-01-21T08:04:32Z

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

xzhangxian1008 · 2026-01-21T08:14:10Z

/run-check-issue-triage-complete

codecov · 2026-01-21T08:35:32Z

Codecov Report

❌ Patch coverage is 24.67532% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.1720%. Comparing base (3adc8ec) to head (8f7c812).
⚠️ Report is 38 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #65694        +/-   ##
================================================
- Coverage   76.3196%   76.1720%   -0.1476%     
================================================
  Files          2041       2067        +26     
  Lines        562141     585393     +23252     
================================================
+ Hits         429024     445906     +16882     
- Misses       132210     136655      +4445     
- Partials        907       2832      +1925

Flag	Coverage Δ
integration	`46.6001% <24.6753%> (+6.9422%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`60.4610% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`65.7853% <ø> (+3.0159%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

solotzg · 2026-01-21T09:00:44Z

/cc @copilot

xzhangxian1008 · 2026-01-21T09:43:53Z

/cc @windtalker @solotzg

solotzg · 2026-01-22T02:09:31Z

+	}
+
+	if len(uncachedServersInfo) > 0 {
+		ch := make(chan [][]types.Datum, len(uncachedServersInfo))


Why use chan?

Why use chan?

deleted

solotzg · 2026-01-22T02:20:35Z

+		waitWg := &sync.WaitGroup{}
+		waitWg.Add(len(uncachedServersInfo))
+		for i := range uncachedServersInfo {
+			go func(info []infoschema.ServerInfo) {


Consider fetching once for the full slice, or pass the single-server slice into the call and use the row’s address only when the fetch is truly per-server.

The extra goroutine layer may be unnecessary since FetchClusterServerInfoWithoutPrivilegeCheck already fans out internally.

Consider fetching once for the full slice, or pass the single-server slice into the call and use the row’s address only when the fetch is truly per-server.

The extra goroutine layer may be unnecessary since FetchClusterServerInfoWithoutPrivilegeCheck already fans out internally.

fixed

xzhangxian1008 · 2026-01-26T07:42:44Z

/hold

ti-chi-bot · 2026-01-26T07:56:59Z

@solotzg: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

solotzg · 2026-01-26T08:10:12Z

+	infos := infoschema.FetchClusterServerInfoWithoutPrivilegeCheck(ctx, sctx.GetSessionVars(), serversInfo, e.serverInfoType, true)
+	rowCount := 0
+	for _, info := range infos {
+		if info.Err != nil {


if info.Err == nil { ?

if info.Err == nil { ?

fixed

solotzg · 2026-01-26T08:10:23Z

+
+	results := make([][]types.Datum, 0, rowCount)
+	for _, info := range infos {
+		if info.Err != nil {


ditto

fixed

windtalker

lgtm

windtalker · 2026-06-22T08:11:36Z

/test check-dev

ti-chi-bot · 2026-06-22T08:51:30Z

[LGTM Timeline notifier]

Timeline:

2026-06-22 08:07:01.075315269 +0000 UTC m=+1984122.145632649: ☑️ agreed by windtalker.
2026-06-22 08:51:29.139139037 +0000 UTC m=+1986790.209456417: ☑️ agreed by winoros.

windtalker · 2026-06-22T10:18:53Z

/test pull-br-integration-test

windtalker · 2026-06-23T01:08:56Z

/hold cancel

windtalker · 2026-06-23T02:50:48Z

/test check-dev2

ti-chi-bot · 2026-06-23T03:48:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, solotzg, windtalker, winoros, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [AilinKid,windtalker,winoros,wjhuang2016]
~~pkg/infoschema/OWNERS~~ [wjhuang2016]
~~pkg/planner/OWNERS~~ [AilinKid,winoros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

windtalker · 2026-06-23T05:23:18Z

/test pull-br-integration-test

xzhangxian1008 · 2026-06-23T05:58:27Z

/retest

xzhangxian1008 · 2026-06-23T12:34:33Z

/cherrypick release-8.5

ti-chi-bot · 2026-06-23T12:35:23Z

@xzhangxian1008: new pull request created to branch release-8.5: #69403.
But this PR has conflicts, please resolve them!

Details

In response to this:

/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

xzhangxian1008 · 2026-06-23T12:41:18Z

/cherrypick release-nextgen-202603

ti-chi-bot · 2026-06-23T12:42:04Z

@xzhangxian1008: new pull request created to branch release-nextgen-202603: #69404.

Details

In response to this:

/cherrypick release-nextgen-202603

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

close #65701

xzhangxian1008 · 2026-07-06T01:48:55Z

/cherrypick release-nextgen-202603

ti-chi-bot · 2026-07-06T01:49:40Z

@xzhangxian1008: failed to apply #65694 on top of branch "release-nextgen-202603":

failed to git commit: exit status 1

Details

In response to this:

/cherrypick release-nextgen-202603

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

close #65701

xzhangxian1008 added 3 commits January 19, 2026 13:47

init, need ut

2f46521

fix

4d45ae2

fix

deddd86

ti-chi-bot Bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2026

ti-chi-bot Bot added do-not-merge/needs-triage-completed and removed do-not-merge/needs-triage-completed labels Jan 21, 2026

add ut

72e66f9

ti-chi-bot Bot removed the do-not-merge/needs-triage-completed label Jan 21, 2026

fix

a00d46c

ti-chi-bot Bot added do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Jan 21, 2026

ti-chi-bot Bot requested review from solotzg and windtalker January 21, 2026 09:43

solotzg reviewed Jan 22, 2026

View reviewed changes

ti-chi-bot Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2026

address comments

29d93c9

solotzg approved these changes Jan 26, 2026

View reviewed changes

solotzg reviewed Jan 26, 2026

View reviewed changes

fix

12df225

windtalker approved these changes Jun 22, 2026

View reviewed changes

ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 22, 2026

rename

8f7c812

winoros approved these changes Jun 22, 2026

View reviewed changes

ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 22, 2026

wjhuang2016 approved these changes Jun 22, 2026

View reviewed changes

ti-chi-bot Bot added the approved label Jun 22, 2026

windtalker removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2026

AilinKid approved these changes Jun 23, 2026

View reviewed changes

ti-chi-bot Bot merged commit 84f3ca5 into pingcap:master Jun 23, 2026
36 checks passed

xzhangxian1008 deleted the fix-tiflash-9663 branch June 23, 2026 12:33

ti-chi-bot mentioned this pull request Jun 23, 2026

planner: cache mpp info to avoid frequent grpc calling (#65694) #69403

Merged

1 of 13 tasks

ti-chi-bot mentioned this pull request Jun 23, 2026

planner: cache mpp info to avoid frequent grpc calling (#65694) #69404

Merged

1 of 13 tasks

ti-chi-bot Bot pushed a commit that referenced this pull request Jul 3, 2026

planner: cache mpp info to avoid frequent grpc calling (#65694) (#69404)

0ac299d

close #65701

ti-chi-bot Bot pushed a commit that referenced this pull request Sep 3, 2026

planner: cache mpp info to avoid frequent grpc calling (#65694) (#69403)

ac41d7e

close #65701

Conversation

xzhangxian1008 commented Jan 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Summary by CodeRabbit

Uh oh!

tiprow Bot commented Jan 21, 2026

Uh oh!

xzhangxian1008 commented Jan 21, 2026

Uh oh!

codecov Bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

solotzg commented Jan 21, 2026

Uh oh!

xzhangxian1008 commented Jan 21, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xzhangxian1008 commented Jan 26, 2026

Uh oh!

ti-chi-bot Bot commented Jan 26, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

windtalker left a comment

Choose a reason for hiding this comment

Uh oh!

windtalker commented Jun 22, 2026

Uh oh!

ti-chi-bot Bot commented Jun 22, 2026

[LGTM Timeline notifier]

Uh oh!

windtalker commented Jun 22, 2026

Uh oh!

windtalker commented Jun 23, 2026

Uh oh!

windtalker commented Jun 23, 2026

Uh oh!

ti-chi-bot Bot commented Jun 23, 2026

Uh oh!

windtalker commented Jun 23, 2026

Uh oh!

xzhangxian1008 commented Jun 23, 2026

Uh oh!

Uh oh!

xzhangxian1008 commented Jun 23, 2026

Uh oh!

ti-chi-bot commented Jun 23, 2026

Uh oh!

xzhangxian1008 commented Jun 23, 2026

Uh oh!

ti-chi-bot commented Jun 23, 2026

Uh oh!

xzhangxian1008 commented Jul 6, 2026

Uh oh!

ti-chi-bot commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

xzhangxian1008 commented Jan 21, 2026 •

edited by coderabbitai Bot

Loading

codecov Bot commented Jan 21, 2026 •

edited

Loading