Repository navigation
planner: index correlated range predicates | tidb-test=pr/2696 #66719
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1580,6 +1580,174 @@ func TestCorColRangeWithRangeMaxSize(t *testing.T) { | |
| }) | ||
| } | ||
|
|
||
| // TestCorColRangePredicateAccess verifies that range predicates (LT/GT/LE/GE) | ||
| // with correlated columns are used as index access conditions, not just | ||
| // post-scan Selection filters. | ||
| func TestCorColRangePredicateAccess(t *testing.T) { | ||
| testkit.RunTestUnderCascades(t, func(t *testing.T, tk *testkit.TestKit, cascades, caller string) { | ||
| tk.MustExec("use test") | ||
| tk.MustExec("drop table if exists t1") | ||
| tk.MustExec("create table t1 (a int primary key, b int, index ib(b))") | ||
| tk.MustExec("insert into t1 values (1,1),(2,2),(3,3),(4,4),(5,5)") | ||
| tk.MustExec("insert into mysql.opt_rule_blacklist value(\"decorrelate\")") | ||
| tk.MustExec("admin reload opt_rule_blacklist") | ||
| defer func() { | ||
| tk.MustExec("delete from mysql.opt_rule_blacklist where name = \"decorrelate\"") | ||
| tk.MustExec("admin reload opt_rule_blacklist") | ||
| }() | ||
|
|
||
| // LT with correlated column on PK (appended to secondary index ib(b)). | ||
| // The index is effectively (b, a) on a clustered table, so t1b.a < t1a.a | ||
| // should appear as an access condition in "decided by". | ||
| rows := tk.MustQuery("explain format='brief' select * from t1 t1a where exists " + | ||
| "(select /*+ NO_DECORRELATE() */ 1 from t1 t1b where t1b.b = t1a.b and t1b.a < t1a.a)").Rows() | ||
| foundRangeAccess := false | ||
| for _, row := range rows { | ||
| info := fmt.Sprintf("%v", row[4]) | ||
| if strings.Contains(info, "decided by") && strings.Contains(info, "lt(test.t1.a, test.t1.a)") { | ||
|
There was a problem hiding this comment. [P2] Test asserts raw EXPLAIN string fragments — brittle CI Why: Evidence:
Contributor
Author
There was a problem hiding this comment. This is not a critical concern. Many tests use this type of string comparison to search for text within the plan. There was a problem hiding this comment. Fair point — ℹ️ Learn more details on Pantheon AI. |
||
| foundRangeAccess = true | ||
| break | ||
| } | ||
| } | ||
| require.True(t, foundRangeAccess, caller+": LT correlated predicate should be in index access conditions") | ||
|
|
||
| // Correctness: rows where exists another row with same b but smaller a. | ||
| // (1,1) -> no row with b=1 and a<1 -> excluded | ||
| // (2,2) -> no row with b=2 and a<2 -> excluded | ||
| // ...all excluded since each (a,b) pair has a=b and is unique. | ||
| tk.MustQuery("select * from t1 t1a where exists " + | ||
| "(select /*+ NO_DECORRELATE() */ 1 from t1 t1b where t1b.b = t1a.b and t1b.a < t1a.a)"). | ||
| Check(testkit.Rows()) | ||
|
|
||
| // Insert duplicate b values so the EXISTS matches. | ||
| tk.MustExec("insert into t1 values (10,1),(20,2)") | ||
| // (1,1) -> exists (10,1) with b=1, a=10 > 1? No, need a < 1. -> excluded | ||
| // But (10,1) -> exists (1,1) with b=1, a=1 < 10 -> included | ||
| // (20,2) -> exists (2,2) with b=2, a=2 < 20 -> included | ||
| tk.MustQuery("select * from t1 t1a where exists " + | ||
| "(select /*+ NO_DECORRELATE() */ 1 from t1 t1b where t1b.b = t1a.b and t1b.a < t1a.a) order by t1a.a"). | ||
| Check(testkit.Rows("10 1", "20 2")) | ||
|
|
||
| // GT with correlated column. | ||
| rows = tk.MustQuery("explain format='brief' select * from t1 t1a where exists " + | ||
| "(select /*+ NO_DECORRELATE() */ 1 from t1 t1b where t1b.b = t1a.b and t1b.a > t1a.a)").Rows() | ||
| foundRangeAccess = false | ||
| for _, row := range rows { | ||
| info := fmt.Sprintf("%v", row[4]) | ||
| if strings.Contains(info, "decided by") && strings.Contains(info, "gt(test.t1.a, test.t1.a)") { | ||
| foundRangeAccess = true | ||
| break | ||
| } | ||
| } | ||
| require.True(t, foundRangeAccess, caller+": GT correlated predicate should be in index access conditions") | ||
|
|
||
| // Correctness for GT. | ||
| // (1,1) -> exists (10,1) with b=1, a=10 > 1 -> included | ||
| // (2,2) -> exists (20,2) with b=2, a=20 > 2 -> included | ||
| // (10,1) -> need b=1 and a>10, only (1,1) has b=1 but a=1 < 10 -> excluded | ||
| // (20,2) -> need b=2 and a>20, only (2,2) has b=2 but a=2 < 20 -> excluded | ||
| tk.MustQuery("select * from t1 t1a where exists " + | ||
| "(select /*+ NO_DECORRELATE() */ 1 from t1 t1b where t1b.b = t1a.b and t1b.a > t1a.a) order by t1a.a"). | ||
| Check(testkit.Rows("1 1", "2 2")) | ||
|
|
||
| // LE with correlated column. | ||
| rows = tk.MustQuery("explain format='brief' select * from t1 t1a where exists " + | ||
| "(select /*+ NO_DECORRELATE() */ 1 from t1 t1b where t1b.b = t1a.b and t1b.a <= t1a.a)").Rows() | ||
| foundRangeAccess = false | ||
| for _, row := range rows { | ||
| info := fmt.Sprintf("%v", row[4]) | ||
| if strings.Contains(info, "decided by") && strings.Contains(info, "le(test.t1.a, test.t1.a)") { | ||
| foundRangeAccess = true | ||
| break | ||
| } | ||
| } | ||
| require.True(t, foundRangeAccess, caller+": LE correlated predicate should be in index access conditions") | ||
|
|
||
| // Correctness for LE. | ||
| // (1,1) -> exists (1,1) with b=1, a=1 <= 1 -> included (self-match) | ||
| // (2,2) -> exists (2,2) with b=2, a=2 <= 2 -> included (self-match) | ||
| // (3,3) -> exists (3,3) with b=3, a=3 <= 3 -> included (self-match) | ||
| // (4,4) -> exists (4,4) with b=4, a=4 <= 4 -> included (self-match) | ||
| // (5,5) -> exists (5,5) with b=5, a=5 <= 5 -> included (self-match) | ||
| // (10,1) -> exists (1,1) with b=1, a=1 <= 10 -> included | ||
| // (20,2) -> exists (2,2) with b=2, a=2 <= 20 -> included | ||
| tk.MustQuery("select * from t1 t1a where exists " + | ||
| "(select /*+ NO_DECORRELATE() */ 1 from t1 t1b where t1b.b = t1a.b and t1b.a <= t1a.a) order by t1a.a"). | ||
| Check(testkit.Rows("1 1", "2 2", "3 3", "4 4", "5 5", "10 1", "20 2")) | ||
|
|
||
| // GE with correlated column. | ||
| rows = tk.MustQuery("explain format='brief' select * from t1 t1a where exists " + | ||
| "(select /*+ NO_DECORRELATE() */ 1 from t1 t1b where t1b.b = t1a.b and t1b.a >= t1a.a)").Rows() | ||
| foundRangeAccess = false | ||
| for _, row := range rows { | ||
| info := fmt.Sprintf("%v", row[4]) | ||
| if strings.Contains(info, "decided by") && strings.Contains(info, "ge(test.t1.a, test.t1.a)") { | ||
| foundRangeAccess = true | ||
| break | ||
| } | ||
| } | ||
| require.True(t, foundRangeAccess, caller+": GE correlated predicate should be in index access conditions") | ||
|
|
||
| // Correctness for GE. | ||
| // (1,1) -> exists (1,1) with b=1, a=1 >= 1 -> included (self-match) | ||
| // (2,2) -> exists (2,2) with b=2, a=2 >= 2 -> included (self-match) | ||
| // (3,3) -> exists (3,3) with b=3, a=3 >= 3 -> included (self-match) | ||
| // (4,4) -> exists (4,4) with b=4, a=4 >= 4 -> included (self-match) | ||
| // (5,5) -> exists (5,5) with b=5, a=5 >= 5 -> included (self-match) | ||
| // (10,1) -> exists (10,1) with b=1, a=10 >= 10 -> included (self-match) | ||
| // (20,2) -> exists (20,2) with b=2, a=20 >= 20 -> included (self-match) | ||
| tk.MustQuery("select * from t1 t1a where exists " + | ||
| "(select /*+ NO_DECORRELATE() */ 1 from t1 t1b where t1b.b = t1a.b and t1b.a >= t1a.a) order by t1a.a"). | ||
| Check(testkit.Rows("1 1", "2 2", "3 3", "4 4", "5 5", "10 1", "20 2")) | ||
|
|
||
| // Reversed argument order: correlated column on the left side of | ||
| // the comparison (t1a.a < t1b.a instead of t1b.a > t1a.a) must | ||
| // also be recognised as an index access condition. | ||
| rows = tk.MustQuery("explain format='brief' select * from t1 t1a where exists " + | ||
| "(select /*+ NO_DECORRELATE() */ 1 from t1 t1b where t1b.b = t1a.b and t1a.a < t1b.a)").Rows() | ||
| foundRangeAccess = false | ||
| for _, row := range rows { | ||
| info := fmt.Sprintf("%v", row[4]) | ||
| if strings.Contains(info, "decided by") && strings.Contains(info, "lt(test.t1.a, test.t1.a)") { | ||
| foundRangeAccess = true | ||
| break | ||
| } | ||
| } | ||
| require.True(t, foundRangeAccess, caller+": reversed-arg LT correlated predicate should be in index access conditions") | ||
|
|
||
| // NULL outer correlated value: col > NULL is NULL (not true), so | ||
| // the correlated range must not produce false-positive matches. | ||
| // Use a separate table since t1.a is PK and cannot be NULL. | ||
| tk.MustExec("drop table if exists t2") | ||
| tk.MustExec("create table t2 (a int, b int, index ib(b))") | ||
| tk.MustExec("insert into t2 values (1,1),(2,2),(3,3),(NULL,1)") | ||
| // Outer row (NULL,1): inner needs b=1 and a < NULL -> no match. | ||
| // Only (2,2) and (3,3) have inner rows with same b and smaller a... no, | ||
| // only rows with duplicate b values can match. b=1 has (1,1) and (NULL,1). | ||
| // (1,1) -> inner (NULL,1) has b=1, a=NULL < 1? -> NULL, no match. -> excluded | ||
| // (NULL,1) -> inner needs b=1 and a < NULL -> NULL, no match. -> excluded | ||
| // (2,2) -> only b=2 row is (2,2) itself, a=2 < 2 is false -> excluded | ||
| // (3,3) -> only b=3 row is (3,3) itself, a=3 < 3 is false -> excluded | ||
| tk.MustQuery("select * from t2 t2a where exists " + | ||
| "(select /*+ NO_DECORRELATE() */ 1 from t2 t2b where t2b.b = t2a.b and t2b.a < t2a.a) order by t2a.a"). | ||
| Check(testkit.Rows()) | ||
| // GT: (NULL,1) -> inner needs b=1 and a > NULL -> no match. | ||
| // (1,1) -> inner (NULL,1) b=1, a=NULL > 1? -> NULL, no match. -> excluded | ||
| tk.MustQuery("select * from t2 t2a where exists " + | ||
| "(select /*+ NO_DECORRELATE() */ 1 from t2 t2b where t2b.b = t2a.b and t2b.a > t2a.a) order by t2a.a"). | ||
| Check(testkit.Rows()) | ||
| // LE: (1,1) -> inner (1,1) b=1, a=1 <= 1 -> true (self). (NULL,1) -> a <= NULL -> no match. | ||
| tk.MustQuery("select * from t2 t2a where exists " + | ||
| "(select /*+ NO_DECORRELATE() */ 1 from t2 t2b where t2b.b = t2a.b and t2b.a <= t2a.a) order by t2a.a"). | ||
| Check(testkit.Rows("1 1", "2 2", "3 3")) | ||
| // GE: same as LE with self-match. | ||
| tk.MustQuery("select * from t2 t2a where exists " + | ||
| "(select /*+ NO_DECORRELATE() */ 1 from t2 t2b where t2b.b = t2a.b and t2b.a >= t2a.a) order by t2a.a"). | ||
| Check(testkit.Rows("1 1", "2 2", "3 3")) | ||
| tk.MustExec("drop table t2") | ||
| }) | ||
| } | ||
|
|
||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| // TestExplainAnalyzeDMLCommit covers the issue #37373. | ||
| func TestExplainAnalyzeDMLCommit(t *testing.T) { | ||
| testkit.RunTestUnderCascades(t, func(t *testing.T, tk *testkit.TestKit, cascades, caller string) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are good changes,
IndexRangeScanshould be better thanIndexFullScan.