*: update kvproto and adapt keyspace fields - #69942
Conversation
Signed-off-by: disksing <i@disksing.com>
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis change updates kvproto, TiKV, and PD dependency pins; migrates keyspace protobuf usage to oneof wrappers and getter accessors; adds keyspace identity propagation and validation; and updates production code, mocks, and tests. ChangesKeyspace protobuf migration
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #69942 +/- ##
================================================
- Coverage 76.3264% 74.9817% -1.3447%
================================================
Files 2041 2111 +70
Lines 558217 588959 +30742
================================================
+ Hits 426067 441612 +15545
- Misses 131250 144923 +13673
- Partials 900 2424 +1524
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
|
/test pull-br-integration-test |
1 similar comment
|
/test pull-br-integration-test |
|
/test pull-integration-e2e-test |
|
/test pull-mysql-client-test |
|
/test pull-br-integration-test |
…pdate-proto Signed-off-by: disksing <i@disksing.com> # Conflicts: # DEPS.bzl # go.mod # go.sum # pkg/meta/autoid/BUILD.bazel # pkg/meta/autoid/autoid_service.go
…pdate-proto Signed-off-by: disksing <i@disksing.com>
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
|
Scope update: this PR now only updates the dependencies and adapts TiDB to the generated protobuf oneofs while preserving the existing numeric keyspace-ID behavior. API V3 |
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
|
/retest-required |
|
#70343 is blocked by this because that one also needs to update |
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
|
/test unit-test |
Signed-off-by: disksing <i@disksing.com>
…pdate-proto Signed-off-by: disksing <i@disksing.com>
|
/test unit-test |
…pdate-proto Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
|
/test pull-br-integration-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, bb7133, GMHDBJD, lcwangchao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
What problem does this PR solve?
Issue Number: close #69944
Problem Summary:
The selected kvproto revision changes several keyspace and AutoID protobuf fields to oneofs. TiDB needs compatible kvproto, client-go, and PD client revisions together with source updates for the generated APIs.
What changed and how does it work?
This PR intentionally does not implement API V3 keyspace identity semantics.
Check List
Tests
make bazel_preparemake lint./tools/check/failpoint-go-test.sh pkg/autoid_service -run '^TestAPI$' -count=1./tools/check/failpoint-go-test.sh pkg/meta/autoid -run '^TestUnsignedAutoid$' -count=1go test -tags=intest ./pkg/extworkload/client -count=1Side effects
Documentation
Release note