Skip to content

*: bump client-go to tidb-8.5 head - #70303

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:release-8.5from
wfxr:bump-up-client-go-8.5
Aug 3, 2026
Merged

ti-chi-bot[bot] merged 1 commit into
pingcap:release-8.5from
wfxr:bump-up-client-go-8.5

Conversation

@wfxr

@wfxr wfxr commented Aug 3, 2026 •

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: ref #69335

Problem Summary:

The tidb-8.5 branch of client-go has upgraded its Go version to 1.25.12. TiDB release-8.5 needs to consume that merged client-go commit so the two repositories use aligned toolchain requirements.

What changed and how does it work?

  • Bump github.com/tikv/client-go/v2 from a2b634d170d9 to c3b50791b9fb (v2.0.8-0.20260803075849-c3b50791b9fb).
  • Refresh go.sum and the Bazel dependency metadata in DEPS.bzl.
  • Regenerate affected BUILD.bazel files with make bazel_prepare.

Check List

Tests

  • Unit test
    • GOTOOLCHAIN=go1.25.12 go test -count=1 -p=1 -tags=intest ./pkg/store/...
    • GOTOOLCHAIN=go1.25.12 go mod verify
    • make check-bazel-prepare
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Summary by CodeRabbit

  • Chores

    • Updated underlying system components to incorporate the latest maintenance improvements.
    • Refined build configuration to support smoother development and release workflows.
  • Tests

    • Improved test distribution for more efficient execution.
    • Enhanced test configuration and coverage for server-related behavior.
    • Added safeguards for tests that may occasionally experience timing-related instability.

Update client-go to c3b50791b9fb, which aligns the tidb-8.5 client module with Go 1.25.12. Refresh the Go and Bazel dependency metadata.

Ref: tikv/client-go#2037
Signed-off-by: Wenxuan Zhang <wenxuangm@gmail.com>
@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 3, 2026
@wfxr wfxr changed the title build(deps): bump client-go to tidb-8.5 head *: bump client-go to tidb-8.5 head Aug 3, 2026
@coderabbitai

coderabbitai Bot commented Aug 3, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The change updates github.com/tikv/client-go/v2 to a newer revision in Go and Bazel metadata. It also adjusts sharding, dependencies, timeout, and flaky status for selected Bazel tests.

Changes

Dependency and test configuration

Layer / File(s) Summary
Update client-go dependency
DEPS.bzl, go.mod
Both dependency declarations now use revision v2.0.8-0.20260803075849-c3b50791b9fb. DEPS.bzl also uses the matching checksum.
Adjust Bazel test targets
pkg/disttask/importinto/BUILD.bazel, pkg/server/BUILD.bazel, pkg/util/sqlkiller/BUILD.bazel
importinto_test uses 19 shards. server_test adds the server error library. sqlkiller_test uses a short timeout and is marked flaky.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: ti-chi-bot, djshow832, yangkeao

Poem

A rabbit checked the version pin,
And found a newer client within.
More test shards split the load,
Server paths gained the code they showed,
Short tests now hop through flaky clover—
Clean builds wait just one hop over.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: updating client-go for the tidb-8.5 branch.
Description check ✅ Passed The description includes the issue, problem, changes, tests, side effects, documentation status, and release note.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 3, 2026
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 3, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-03 08:44:34.857562396 +0000 UTC m=+2431260.893657452: ☑️ agreed by cfzjywxk.
  • 2026-08-03 08:48:36.320220898 +0000 UTC m=+2431502.356315954: ☑️ agreed by ekexium.

@ti-chi-bot

ti-chi-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, D3Hunter, ekexium

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Aug 3, 2026
@codecov

codecov Bot commented Aug 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-8.5@4f4bc88). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #70303   +/-   ##
================================================
  Coverage               ?   55.4410%           
================================================
  Files                  ?       1849           
  Lines                  ?     670985           
  Branches               ?          0           
================================================
  Hits                   ?     372001           
  Misses                 ?     271223           
  Partials               ?      27761           
Flag Coverage Δ
integration 38.6415% <ø> (?)
unit 65.2130% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 55.3108% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 56.1521% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wfxr

wfxr commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

/retest

@coderabbitai coderabbitai Bot mentioned this pull request Aug 3, 2026
2 of 13 tasks
@ti-chi-bot ti-chi-bot Bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 3, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit c699fa6 into pingcap:release-8.5 Aug 3, 2026
19 checks passed
ekexium added a commit to ekexium/tidb that referenced this pull request Aug 6, 2026
…pingcap#2044)

Bump github.com/tikv/client-go/v2 from v2.0.8-0.20260803075849-c3b50791b9fb
to v2.0.8-0.20260806041825-494edbd79be9 on tidb-8.5, on top of the
previous bump in pingcap#70303. This brings:

- internal/locate: probe follower once when the cached leader keeps
  rejecting leader reads with ServerIsBusy(0) (pingcap#2041) (pingcap#2044): when a
  store's read pool is wedged, leader reads are rejected with
  ServerIsBusy(0) at the pool entrance so no NotLeader is returned even
  if PD has moved the leader away; after 2 such rejections the selector
  probes a follower once and heals the stale leader cache via the
  NotLeader hint (ref tikv/client-go#2028)

Signed-off-by: Ziqian Qin <eke@fastmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants