*: bump client-go to tidb-8.5 head - #70303
Conversation
Update client-go to c3b50791b9fb, which aligns the tidb-8.5 client module with Go 1.25.12. Refresh the Go and Bazel dependency metadata. Ref: tikv/client-go#2037 Signed-off-by: Wenxuan Zhang <wenxuangm@gmail.com>
📝 WalkthroughWalkthroughThe change updates ChangesDependency and test configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, D3Hunter, ekexium The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #70303 +/- ##
================================================
Coverage ? 55.4410%
================================================
Files ? 1849
Lines ? 670985
Branches ? 0
================================================
Hits ? 372001
Misses ? 271223
Partials ? 27761
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/retest |
…pingcap#2044) Bump github.com/tikv/client-go/v2 from v2.0.8-0.20260803075849-c3b50791b9fb to v2.0.8-0.20260806041825-494edbd79be9 on tidb-8.5, on top of the previous bump in pingcap#70303. This brings: - internal/locate: probe follower once when the cached leader keeps rejecting leader reads with ServerIsBusy(0) (pingcap#2041) (pingcap#2044): when a store's read pool is wedged, leader reads are rejected with ServerIsBusy(0) at the pool entrance so no NotLeader is returned even if PD has moved the leader away; after 2 such rejections the selector probes a follower once and heals the stale leader cache via the NotLeader hint (ref tikv/client-go#2028) Signed-off-by: Ziqian Qin <eke@fastmail.com>
What problem does this PR solve?
Issue Number: ref #69335
Problem Summary:
The
tidb-8.5branch of client-go has upgraded its Go version to 1.25.12. TiDB release-8.5 needs to consume that merged client-go commit so the two repositories use aligned toolchain requirements.What changed and how does it work?
github.com/tikv/client-go/v2froma2b634d170d9toc3b50791b9fb(v2.0.8-0.20260803075849-c3b50791b9fb).go.sumand the Bazel dependency metadata inDEPS.bzl.BUILD.bazelfiles withmake bazel_prepare.Check List
Tests
GOTOOLCHAIN=go1.25.12 go test -count=1 -p=1 -tags=intest ./pkg/store/...GOTOOLCHAIN=go1.25.12 go mod verifymake check-bazel-prepareSide effects
Documentation
Release note
Summary by CodeRabbit
Chores
Tests