[ti-chi-bot]

This is an automated cherry-pick of #67645

What problem does this PR solve?

Issue Number: close #67623

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Summary by CodeRabbit

• Tests
  • Updated Google Cloud Storage backup and restore test configurations to use the base endpoint URL and complete service-account credentials.
  • Legacy backup and restore checks now run only when explicitly enabled; standard test runs skip those checks. This keeps legacy verification separate while preserving coverage for current backup and restore workflows.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 994f6276-478c-48e2-82b8-97c29e3a8ed1

📥 Commits

Reviewing files that changed from the base of the PR and between bfef925 and 6d08126.

📒 Files selected for processing (3)

• br/tests/br_gcs/run.sh
• br/tests/docker_compatible_gcs/_run.sh
• br/tests/docker_compatible_gcs/prepare.sh

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The GCS test scripts now use endpoint base URLs, add missing service-account fields, and run the BR v4.0.8 backup and restore checks only when TEST_LEGACY_BR_GCS=true.

Changes: GCS integration test updates

Layer / File(s)	Summary
BR GCS test flow br/tests/br_gcs/run.sh	The script adds project_id and private_key_id, removes /storage/v1/ from current BR endpoints, and gates the v4.0.8 backup, restore, cleanup, and row-count checks on TEST_LEGACY_BR_GCS=true.
Docker-compatible GCS endpoints br/tests/docker_compatible_gcs/_run.sh, br/tests/docker_compatible_gcs/prepare.sh	The scripts add service-account fields and remove /storage/v1/ from the backup and restore endpoints.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: gengliqi

Merge Risk: ⚪ Minimal · up to 6d081

This change updates GCS integration test scripts and makes the legacy BR flow opt-in. No concrete merge-blocking risk was found. The tests were not run in this review.

Pre-merge checks · 4 · 1

Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check		The description includes the issue reference, integration-test selection, side-effect and documentation checklists, and release note. However, the Problem Summary and What changed and how does it work…	Add a concise problem summary and describe the changes, including the fake-GCS credential and endpoint updates and the legacy BR test gating. Retain the issue reference and test details.

Passed checks (4 passed)

Check name	Status	Explanation
Title check		The title clearly identifies the package area and the primary change: fixing the fake-GCS test. It is concise and related to the changeset.
Linked Issues check		Issue #67623 is closed. It supplies historical context only. No active directly linked issue supplies coding requirements for this pull request. The change summary is consistent with the historical fa…
Out of Scope Changes check		The reported changes are limited to three BR GCS test scripts. They update fake service-account fields and GCS endpoint URLs, and gate the legacy test flow. These changes are connected to the fake GCS…
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…

Full details: Description check

Explanation

The description includes the issue reference, integration-test selection, side-effect and documentation checklists, and release note. However, the Problem Summary and What changed and how does it work? sections are empty, so it does not explain the change or its purpose.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{This rabbit packs a GCS URL,
And adds the keys the tests require.
The legacy path waits for its flag,
Backup and restore hop along,
While I nibble carrots by the fire.}

_{Comment @coderabbitai help to get the list of available commands.}

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2026-10-13 06:55:42.392654019 +0000 UTC m=+714152.139884868: ☑️ agreed by gengliqi.
• 2026-10-13 07:08:00.699115431 +0000 UTC m=+714890.446346290: ☑️ agreed by D3Hunter.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-8.5-20260608-v8.5.6@bfef925). Learn more about missing BASE report.

Additional details and impacted files

@@                       Coverage Diff                        @@
##             release-8.5-20260608-v8.5.6     #71932   +/-   ##
================================================================
  Coverage                               ?   55.5255%           
================================================================
  Files                                  ?       1823           
  Lines                                  ?     655149           
  Branches                               ?          0           
================================================================
  Hits                                   ?     363775           
  Misses                                 ?     264347           
  Partials                               ?      27027           

Flag	Coverage Δ
integration	39.1396% <ø> (?)
unit	64.9539% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9954% <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	62.2624% <0.0000%> (?)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: D3Hunter, gengliqi, LykxSassinator
Once this PR has been reviewed and has the lgtm label, please assign 3pointer for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• br/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

@LykxSassinator: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[gengliqi]

/retest