Skip to content

fts: Rename for good - #366

Merged
breezewish merged 1 commit into
masterfrom
wenxuan/fts_refine_1
May 20, 2025
Merged

breezewish merged 1 commit into
masterfrom
wenxuan/fts_refine_1

Conversation

@breezewish

Copy link
Copy Markdown
Member

What problem does this PR solve?

It appears that Filter / TopK is not distinguishable enough.

What really matters is scoring is needed or not.

What is changed and how it works?

What's Changed:

Rename Filter -> NoScore.

Rename TopK -> WithScore.

Under WithScore mode, TopK is still optional.

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Signed-off-by: Wish <breezewish@outlook.com>

@wshwsh12 wshwsh12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breezewish
breezewish merged commit b98e57f into master May 20, 2025
@breezewish
breezewish deleted the wenxuan/fts_refine_1 branch May 20, 2025 07:34
AilinKid pushed a commit to AilinKid/tipb that referenced this pull request Sep 3, 2026
Signed-off-by: Wish <breezewish@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants