Skip to content

Files panel "Open" and "Reveal in Finder" run on the server machine in a remote environment #29718

Description

@grahamfarrar

What happened

The desktop app on a MacBook is connected to a T3 server on another Mac (a remote environment). In the Files panel, right-clicking a file shows Open and Reveal in Finder. Neither does anything on the MacBook. Both run on the server Mac instead, so the file opens or Finder appears on a screen I'm not using.

Expected

In a remote environment, the file tree menu should do the same thing as chat file links: hide the local shell actions, or offer actions that work from the client, such as opening the file in the editor through the remote-links path (vscode-remote over SSH) that the file preview's editor button already uses.

Possibly relevant (not confirmed)

The file tree menu builds its items from useFileContextMenu (fileContextMenu.ts#L89-L105). That hook shows Open and Reveal whenever the server reports file-manager among availableEditors, and activate sends openInEditor to that environment's server.

Chat file links gate the same actions on canUseMarkdownFileShellActions, which requires remoteOpenMode === "local-exec" (MarkdownFileLink.logic.ts#L10-L16, ChatMarkdown.tsx#L558-L563). FileBrowserPanel doesn't apply that check (FileBrowserPanel.tsx#L192-L204).

Related: #28602 (remote "Open in" links always use the Tailscale name).

Version

Server 0.1.6 (macOS, background service), desktop app 0.1.6 on macOS, remote environment over Tailscale.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions