Skip to content

fix(web): retry failed thread loads - #10428

Open
Gigioxx wants to merge 1 commit into
pingdotgg:mainfrom
Gigioxx:t3code/fix-issue-10418
Open

fix(web): retry failed thread loads#10428
Gigioxx wants to merge 1 commit into
pingdotgg:mainfrom
Gigioxx:t3code/fix-issue-10418

Conversation

@Gigioxx

@Gigioxx Gigioxx commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Failed thread subscriptions left web/desktop showing “Loading messages…” even after the runtime recorded an error. Show that error in the existing banner and let Retry refresh the thread atom on the current connection. Keep the thread shell visible and sending blocked while history is missing; cached history and ordinary dismissible session errors keep their existing behavior.

Fixes #10418. Reproduced with an injected subscription failure in an isolated local web client, then verified a failed retry and successful recovery after removing the fault, without restarting the app. This confirms the stuck-loading path, not disk exhaustion as the original trigger. The temporary fault and synthetic data are not included in the diff.

Verification: 67 focused tests pass, including failed-load presentation and mounted-atom recovery with empty/cached history. Web and client-runtime typechecks pass. Scoped lint and React Doctor report existing warnings only. Web and desktop share this view; mobile, provider adapters, contracts, and connection transports are unchanged. Browser verification used the local web client, not a packaged desktop build.

Before After
Failed subscription still shows Loading messages Failed subscription shows its error and Retry

Retry recording: failure persists, then history recovers without restart

Model: GPT-6. Harness: Codex in T3 Code.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 6, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This is a focused thread-loading bug fix: failed subscriptions now show their existing error and can be retried without restarting, while normal loading and dismissible errors remain unchanged. The production changes are localized and supported by client-runtime and sync-phase tests.

Not approved because:

  • Monthly spending limit reached (workspace setting). Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Threads remain stuck on “Loading messages…” after disk space is freed

1 participant