Skip to content

feat(web): highlight sidebar threads waiting for input - #10633

Closed
flamboh wants to merge 1 commit into
pingdotgg:mainfrom
flamboh:fix/sidebar-input-ring
Closed

flamboh wants to merge 1 commit into
pingdotgg:mainfrom
flamboh:fix/sidebar-input-ring

Conversation

@flamboh

@flamboh flamboh commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Note

🤖 GPT-6 on behalf of Oliver

ELI5

Threads waiting for an answer now have a visible indigo ring in the sidebar.

Problem

The small "Input" label was easy to miss, especially because inactive rows were dimmed.

Fix

Add a static 2px inset ring and keep input rows at full opacity in the current web/desktop sidebar. The ring follows the existing input status, including clearing after an answer, and preserves row dimensions.

Validation: 158 sidebar logic tests, web typecheck, formatting, and focused lint passed with existing lint warnings. Browser checks covered light/dark themes, active state, input clearing/restoring, and unchanged dimensions. Code review found no actionable issues.

UI Changes

Captured in Chromium on a temporary dev route rendering the actual sidebar row component with fixed fixtures.

Before

Light Dark
Before in light theme Before in dark theme

After

Light Dark
After in light theme After in dark theme

Made with GPT-6 in Codex.

Note

Highlight sidebar threads waiting for input with indigo ring

Updates SidebarThreadRow in Sidebar.tsx to show an indigo inset ring when thread status is input. It also prevents the in-flight opacity dimming from applying to input rows so they remain fully visible.

Macroscope summarized 4d67652.

Summary by CodeRabbit

  • Style
    • In-progress threads awaiting input now display a highlighted indigo outline for improved visibility.
    • Other in-progress threads continue to use dimmed styling.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 8, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 4d67652

Macroscope's review found this PR approvable — This is a focused one-file sidebar UI fix that adds a visible input-state ring and prevents those rows from being dimmed, without changing thread behavior, layout dimensions, data, or configuration. It is a bounded visual correction with no product-default or static-analysis changes.

You can add or adjust custom eligibility rules. Learn more.

@flamboh flamboh changed the title fix(web): highlight sidebar threads waiting for input feat(web): highlight sidebar threads waiting for input Sep 8, 2026
@coderabbitai

coderabbitai Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 716a03eb-90a1-4f31-9b27-c08e1bf0ff28

📥 Commits

Reviewing files that changed from the base of the PR and between 299404a and 4d67652.

📒 Files selected for processing (1)
  • apps/web/src/components/Sidebar.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The sidebar now displays input-status threads with an indigo inset ring. These rows no longer use in-flight opacity dimming.

Changes

Sidebar row surface states

Layer / File(s) Summary
Input row surface state
apps/web/src/components/Sidebar.tsx
The row surface comment describes the inset-ring model. Input-status rows use an indigo inset ring and bypass in-flight opacity dimming.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 4d676

Threads awaiting input are now more visible in the sidebar through a static indigo inset ring while retaining existing sizing and status-clearing behavior. The change is ready to merge.

Suggested reviewers: juliusmarminge, t3dotgg, maria-rcks

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: highlighting sidebar threads that are waiting for input.
Description check ✅ Passed The description explains the problem, fix, validation, and UI changes. It includes before-and-after screenshots and remains focused. The repository checklist is not included, but the substantive requi…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

flamboh commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

Note

🤖 GPT-6 on behalf of Oliver

Closing because #9810 already proposes a static indigo border for pending-input threads as part of its question-navigation improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant