fix(mobile): pin expo-audio so the release smoke patch stays in use by saphid · Pull Request #11518 · pingdotgg/t3code

saphid · 2026-09-13T03:54:18Z

Summary

apps/mobile/package.json declares expo-audio as ~57.0.4 while patchedDependencies carries expo-audio@57.0.4. The release smoke (node scripts/release-smoke.ts) regenerates the lockfile in an isolated manifest root via vp install --lockfile-only --ignore-scripts; fresh resolution of ~57.0.4 now selects 57.0.5, so the pinned patch is unused and pnpm fails with ERR_PNPM_UNUSED_PATCH, failing the Release Smoke job.

This pins expo-audio to 57.0.4 — the same fix already landed on main in #11426 — so the still-needed patch stays applied. The patch (error reporting in AudioRecorder.didFinish) is not present upstream in 57.0.5, so removing it would regress recording-error behavior; porting it to 57.0.5 is unnecessary scope.

Review ranges

The head carries three distinct commits; please review each range independently:

0d606c8a..88301853a — this PR's repair: the expo-audio pin + lockfile specifier (manifest-only).
88301853a..7c6fdd0f8 — prerequisite CI repair cherry-picked from fix(ci): register the live background verifier and drop dead v2 exports #11513 (knip: register the live background verifier and drop dead v2 exports) to keep the Check job green on this base.
7c6fdd0f8..cec7012f7c — prerequisite CI repair cherry-picked from fix(mobile): rebuild pending-move fixtures with the shared shell factory #11517 (rebuild pending-move fixtures with the shared shell factory) to keep the Test job green on this base.

The dependency commits are distinct, credited, and owned by their own PRs; they exist here only so this head is fully green against the current base.

Test plan

node scripts/release-smoke.ts before: exit 1 with ERR_PNPM_UNUSED_PATCH ... expo-audio@57.0.4
node scripts/release-smoke.ts after: exit 0, Release smoke checks passed. — isolated install resolves expo-audio@57.0.4 and the patch applies
vp install --frozen-lockfile --ignore-scripts: exit 0, lockfile up to date
Verified patch applied in installed expo-audio@57.0.4 (ios/AudioRecorder.swift carries the didFinish error-state fix); upstream 57.0.5 tarball confirmed still unpatched
vp test run scripts/resolve-nightly-release.test.ts: 7/7 pass
CI Release Smoke check: green on this head

Generated with SWE-2 via Devin/T3 (OV2 delivery campaign, issue saphid/t3code-personal#298).

apps/mobile declares expo-audio as ~57.0.4 while patchedDependencies carries expo-audio@57.0.4. The release smoke regenerates the lockfile in an isolated root, where ~57.0.4 resolves to the newer 57.0.5 and pnpm fails with ERR_PNPM_UNUSED_PATCH. Pin the dependency to 57.0.4, matching the upstream fix in pingdotgg#11426, so the still-needed patch (error reporting in AudioRecorder.didFinish, not present upstream in 57.0.5) stays applied and frozen installs stay reproducible. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

macroscopeapp · 2026-09-13T03:55:50Z

Approvability

Verdict: Approved at cec7012

Macroscope's review found this PR approvable — The PR is a bounded dependency-resolution fix that preserves the existing patched mobile audio package, alongside test maintenance, a legitimate Knip entry-point registration, and dead-code cleanup. No new capability, product default, sensitive area, or material existing-path behavior change is introduced.

^{You can add or adjust custom eligibility rules. Learn more.}

knip:check reported apps/server/scripts/verify-background-live.ts as an unused file even though docs/operations/background-verification.md documents it as the live provider verification entry point. Register it as an apps/server knip entry alongside the other runnable scripts. The exports pass also flagged two exports that lost their consumers in the v2 port: autoSettlementSettingsKey lost the unit tests that used it (restored from main's ThreadSettlementReactor.test.ts), and foldUserInputActivities plus projectQuestionToolInput became dead once the server started attaching questionAnswer to resolved turn items. Model: SWE-2 High via T3 Code (Cursor harness). Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

The "hide subagent threads from v2 lists" change made getThreadListV2OrderedSection read thread.lineage, but the pending-move suite still hand-cast partial EnvironmentThreadShell rows, so all five cases crashed with "Cannot read properties of undefined". Build the rows through makeThreadShellFixture so the fixtures track every field the shared section helper reads; assertions are unchanged. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

Dismissing prior approval to re-evaluate cec7012

…11518) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

Release Smoke regenerates the lockfile in an isolated root, where the transitive expo-modules-core range resolves to a newer 57.x and pnpm fails with ERR_PNPM_UNUSED_PATCH for expo-modules-core@57.0.14. Pin it via overrides — the same mechanism the workspace already uses for expo-constants, expo-router and @expo/metro-config — so the declared patch stays applied. Carried dependency repair for the shared-base failure blocking this PR (task-27 scope; PR pingdotgg#11518's expo-audio pin was already absorbed by the rewritten base and did not cover this package). Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

…11518) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

Release Smoke regenerates the lockfile in an isolated root, where the transitive expo-modules-core range resolves to a newer 57.x and pnpm fails with ERR_PNPM_UNUSED_PATCH for expo-modules-core@57.0.14. Pin it via overrides — the same mechanism the workspace already uses for expo-constants, expo-router and @expo/metro-config — so the declared patch stays applied. Carried dependency repair for the shared-base failure blocking this PR (task-27 scope; PR pingdotgg#11518's expo-audio pin was already absorbed by the rewritten base and did not cover this package). Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

…11518) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 13, 2026

macroscopeapp Bot previously approved these changes Sep 13, 2026

View reviewed changes

github-actions Bot and others added 2 commits September 13, 2026 14:01

github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Sep 13, 2026

macroscopeapp Bot approved these changes Sep 13, 2026

View reviewed changes

This was referenced Sep 13, 2026

fix(mobile): rebuild pending-move fixtures with the shared shell factory #11517

Closed

fix(ci): register the live background verifier and drop dead v2 exports #11513

Closed

juliusmarminge merged commit a8cc38b into pingdotgg:t3code/codex-turn-mapping Sep 13, 2026
24 checks passed

saphid mentioned this pull request Sep 13, 2026

fix(server): restart the live session on model changes after dead records #11505

Merged

Navigation Menu

Uh oh!

fix(mobile): pin expo-audio so the release smoke patch stays in use - #11518

fix(mobile): pin expo-audio so the release smoke patch stays in use#11518
juliusmarminge merged 3 commits into
pingdotgg:t3code/codex-turn-mappingfrom
saphid:work/ov2-20260913-27

saphid commented Sep 13, 2026 •

edited

Loading

Uh oh!

macroscopeapp Bot commented Sep 13, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

saphid commented Sep 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Review ranges

Test plan

Uh oh!

macroscopeapp Bot commented Sep 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

saphid commented Sep 13, 2026 •

edited

Loading

macroscopeapp Bot commented Sep 13, 2026 •

edited

Loading