Skip to content

fix(swift-ios): load file folders on demand - #11688

Merged
t3dotgg merged 1 commit into
t3code/rebuild-mobile-app-swiftfrom
t3code/swift-parity-lazy-files
Sep 14, 2026
Merged

t3dotgg merged 1 commit into
t3code/rebuild-mobile-app-swiftfrom
t3code/swift-parity-lazy-files

Conversation

@t3dotgg

@t3dotgg t3dotgg commented Sep 14, 2026

Copy link
Copy Markdown
Member

The SwiftUI file browser fetched the whole workspace for each folder and could not show ignored files.

Request only the opened folder, cache its listing, and dim ignored entries. Keep older servers usable, route requests through the thread environment and worktree, and keep cached entries with Retry after failed refreshes. Older loads cannot overwrite newer results.

Ports the folder API change. Includes the stale-refresh behavior from the earlier SwiftUI refresh fix. That PR is still open.

Verification: 15 focused native tests passed with zero failures. Covers loading, retries, stale results, cache scope, ignored entries, old servers, and Windows paths. Swift syntax parsing and git diff --check pass. UI evidence is pending the shared verification pass.

Created with Codex.

@cursor

cursor Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 14, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR changes the production iOS file browser from recursive indexed loading to per-folder on-demand RPCs, adding caching, refresh, stale-request handling, path normalization, and ignored-file presentation. The new request parameter also activates a materially different downstream filesystem-listing path, so the behavior change warrants human review.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.6 KiB 15.1 KiB
Codex Thread snapshot wire 7.0 KiB 7.3 KiB
Codex Live turn WebSocket wire 6.5 KiB 7.8 KiB
Codex Live turn WebSocket decoded 57.0 KiB 66.4 KiB
Codex Live turn messages 8 21
Claude Total thread wire 13.5 KiB 15.1 KiB
Claude Thread snapshot wire 7.1 KiB 7.3 KiB
Claude Live turn WebSocket wire 6.5 KiB 7.8 KiB
Claude Live turn WebSocket decoded 57.8 KiB 66.4 KiB
Claude Live turn messages 8 21

Baseline: unavailable · PR result: 13e556f · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.9 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@t3dotgg
t3dotgg merged commit d485c0c into t3code/rebuild-mobile-app-swift Sep 14, 2026
21 checks passed
@t3dotgg
t3dotgg deleted the t3code/swift-parity-lazy-files branch September 14, 2026 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500-999 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant