Skip to content

fix(web): keep PR controls readable in narrow panels #11962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 3 commits into from
Sep 15, 2026
+4 −10
Merged

fix(web): keep PR controls readable in narrow panels #11962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
303cd4b
fix(web): keep PR controls readable in narrow panels
Bil0000 Sep 15, 2026
243ba10
fix(web): remove duplicate PR toolbar diff totals
Bil0000 Sep 15, 2026
ec66fe2
fix(web): keep PR code controls on one row
Bil0000 Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions apps/web/src/components/pullRequest/PullRequestCodeTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ import { orderDiffFiles } from "./pullRequestFileOrder.logic";
import {
buildFileDiffRenderKey,
fnv1a32,
getDiffLineStat,
getRenderablePatch,
resolveDiffThemeName,
resolveFileDiffPath,
Expand Down Expand Up @@ -546,7 +545,6 @@ function PullRequestCodeTab({
toggledFiles,
],
);
const lineStat = useMemo(() => getDiffLineStat(files), [files]);
const omittedFileStats = useMemo(
() =>
new Map(
Expand Down Expand Up @@ -1040,7 +1038,7 @@ function PullRequestCodeTab({
{orderedCommits.length > 0 ? (
<DropdownMenu>
<DropdownMenuTrigger
className="inline-flex h-6 max-w-64 items-center gap-1 rounded-md bg-accent px-2 text-xs font-medium text-accent-foreground outline-none transition-colors hover:bg-accent/80 focus-visible:ring-2 focus-visible:ring-ring"
className="inline-flex h-6 min-w-0 max-w-64 items-center gap-1 rounded-md bg-accent px-2 text-xs font-medium text-accent-foreground outline-none transition-colors hover:bg-accent/80 focus-visible:ring-2 focus-visible:ring-ring"
aria-label={`Diff scope: ${scopeLabel}`}
>
<span className="truncate">{scopeLabel}</span>
Expand Down Expand Up @@ -1089,7 +1087,7 @@ function PullRequestCodeTab({
) : null}
{/* One count, and the caveats as icons that carry their own words. Spelled out they
competed for a strip this narrow and every one of them truncated to nothing. */}
<PullRequestMetaLine>
<PullRequestMetaLine className="shrink-0">
<span className="shrink-0 tabular-nums">
{files.length} {files.length === 1 ? "file" : "files"}
{nextCursor === null ? "" : "+"}
Expand Down Expand Up @@ -1124,11 +1122,6 @@ function PullRequestCodeTab({
</PullRequestMetaLine>
</div>
<div className="flex shrink-0 items-center gap-1">
<PullRequestDiffStat
additions={lineStat.additions}
deletions={lineStat.deletions}
className="mr-1"
/>
{fileKeys.length > 0 ? (
<Tooltip>
<TooltipTrigger
Expand Down
3 changes: 2 additions & 1 deletion apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2459,10 +2459,11 @@ export function PullRequestDetailPanel({

{detail ? (
<nav
className="col-span-2 flex min-w-0 items-center gap-1 overflow-x-auto border-t border-border/60 px-4 py-2 [scrollbar-width:none] [&::-webkit-scrollbar]:hidden"
className="col-span-2 flex min-w-0 flex-wrap items-center gap-2 border-t border-border/60 px-4 py-2"
aria-label="Pull request tabs"
>
<ToggleGroup
className="shrink-0"
size="segmented"
variant="segmented"
value={[tab]}
Expand Down
Loading