Repository navigation
feat: HTML renders can send the reader's answer to the thread #17235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juliusmarminge
wants to merge
6
commits into
main
Choose a base branch
from
feat/html-render-send
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+378
−24
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8c192c7
feat: HTML renders can send the reader's answer to the thread
juliusmarminge f0e4ccc
merge main before rebuilding HTML render replies
juliusmarminge 220ba6f
test(shared): specify HTML render reply bridge behavior
juliusmarminge cdef079
feat: let HTML render pages send reader replies to their thread
juliusmarminge 78a312d
fix: reject HTML replies on clients without message support
juliusmarminge 3fe73a6
fix(web): keep HTML replies available after thread switches
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win
Mobile sends on scroll drags, not only on taps.
onTouchStartsetslastTouchAtfor every touch on the container. A touch that starts a vertical scroll of the thread feed over a nested render also counts. On mobile, the page-sidenavigator.userActivationcheck is skipped (!w&&...inBOOTSTRAP_SCRIPT). A page can also callwindow.ReactNativeWebView.postMessagedirectly. The host-side touch gate is therefore the only control.Trigger: an agent-authored page listens for
touchstartorscroll, then callst3.send(...). The reader scrolls the feed past the render. The host accepts the request and queues a message as the reader's own. On web, a scroll does not grant transient activation, so web rejects the same request. This mismatch breaks the guide's statement that "mobile accepts one message per tap".Record the gate only for a completed tap. Set the timestamp in
onTouchEnd, and only when the touch moved less than a small threshold and lasted a short time. Then shorten the acceptance window to match.Proposed fix
Add
const touchStart = useRef<{ x: number; y: number; at: number } | null>(null);next tolastTouchAt.🤖 Prompt for AI Agents