Repository navigation
perf(web): the branch picker compiles without manual memoization - #20557
Merged
Merged
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a localized React Compiler cleanup that removes redundant manual memoization while preserving the branch picker's existing handler logic and effect behavior. It introduces no new capability, schema, product default, or sensitive-area change. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Contributor
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge
force-pushed
the
rc2/branch-picker
branch
from
October 17, 2026 04:41
f635792 to
9d6c9cd
Compare
macroscopeapp
Bot
dismissed
their stale review
October 17, 2026 04:41
Dismissing prior approval to re-evaluate 9d6c9cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BranchPicker wrapped its open, pagination and scroll-fade handlers in manual useCallback, which kept it out of the React Compiler strict bar.
The handlers are now plain functions. The compiler caches them on the same inputs, and the scroll-fade updater stays a constant so the layout effect still only re-runs when the popup opens. The file joins REACT_COMPILED_FILES. No behaviour change.
🤖 Generated with Claude Code (Claude Opus 5.5)