Skip to content

perf(web): the diff worker pool provider compiles without manual memoization #20584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 17, 2026
Merged

perf(web): the diff worker pool provider compiles without manual memoization #20584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 24 additions & 30 deletions apps/web/src/components/DiffWorkerPoolProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,8 @@ import { WorkerPoolContext, useWorkerPool } from "@pierre/diffs/react";
import { WorkerPoolManager } from "@pierre/diffs/worker";
import DiffsWorker from "@pierre/diffs/worker/worker.js?worker";
import * as Schema from "effect/Schema";
import {
useCallback,
useEffect,
useMemo,
useState,
useSyncExternalStore,
type ReactNode,
} from "react";
import { useEffect, useState, useSyncExternalStore, type ReactNode } from "react";
import { useStableCallback } from "../hooks/useStableCallback";
import { useTheme } from "../hooks/useTheme";
import { resolveDiffThemeName, type DiffThemeName } from "../lib/diffRendering";
import { PREFERRED_HIGHLIGHTER } from "../lib/syntaxHighlighting";
Expand All @@ -25,6 +19,11 @@ export class DiffWorkerError extends Schema.TaggedError<DiffWorkerError>()("Diff
}

const DIFF_WORKER_IDLE_TTL_MS = 30_000;
function resolveDiffWorkerPoolSize() {
const cores =
typeof navigator === "undefined" ? 4 : Math.max(1, navigator.hardwareConcurrency || 4);
return Math.max(2, Math.min(6, Math.floor(cores / 2)));
}
let sharedWorkerPool:
| {
readonly pool: WorkerPoolManager;
Expand Down Expand Up @@ -129,29 +128,24 @@ function DiffWorkerReady({ children }: { children?: ReactNode }) {
export function DiffWorkerPoolProvider({ children }: { children?: ReactNode }) {
const { resolvedTheme } = useTheme();
const diffThemeName = resolveDiffThemeName(resolvedTheme);
const workerPoolSize = useMemo(() => {
const cores =
typeof navigator === "undefined" ? 4 : Math.max(1, navigator.hardwareConcurrency || 4);
return Math.max(2, Math.min(6, Math.floor(cores / 2)));
}, []);
const [workerPoolSize] = useState(resolveDiffWorkerPoolSize);
// A new subscribe identity makes React release and reacquire the shared pool on every render.
const subscribe = useStableCallback((onStoreChange: () => void) => {
if (typeof window === "undefined") return () => {};
const entry = acquireDiffWorkerPool(diffThemeName, workerPoolSize);
onStoreChange();
return () => {
entry.consumers -= 1;
if (entry.consumers !== 0) return;
entry.idleTimer = setTimeout(() => {
entry.idleTimer = undefined;
entry.pool.terminate();
if (sharedWorkerPool === entry) sharedWorkerPool = undefined;
}, DIFF_WORKER_IDLE_TTL_MS);
};
});
const workerPool = useSyncExternalStore(
useCallback(
(onStoreChange) => {
if (typeof window === "undefined") return () => {};
const entry = acquireDiffWorkerPool(diffThemeName, workerPoolSize);
onStoreChange();
return () => {
entry.consumers -= 1;
if (entry.consumers !== 0) return;
entry.idleTimer = setTimeout(() => {
entry.idleTimer = undefined;
entry.pool.terminate();
if (sharedWorkerPool === entry) sharedWorkerPool = undefined;
}, DIFF_WORKER_IDLE_TTL_MS);
};
},
[diffThemeName, workerPoolSize],
),
subscribe,
() => sharedWorkerPool?.pool,
() => undefined,
);
Expand Down
Loading