Skip to content

perf(web): the font previews compile with the React Compiler #20601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 17, 2026
Merged

perf(web): the font previews compile with the React Compiler #20601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions apps/web/src/components/settings/SettingsFontPreviews.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { preloadPatchFile } from "@pierre/diffs/ssr";
import { useCallback, useEffect, useRef, useState } from "react";
import { useEffect, useRef, useState } from "react";
import { ComposerPromptEditor, type ComposerPromptEditorHandle } from "../ComposerPromptEditor";
import { EMPTY_COMPOSER_CONTEXT_RECORDS } from "../composerContextPresentation";
import { terminalThemeFromApp } from "../ThreadTerminalDrawer";
Expand All @@ -22,10 +22,10 @@ export function PromptFontPreview() {
const editorRef = useRef<ComposerPromptEditorHandle>(null);
const [prompt, setPrompt] = useState(PROMPT_PREVIEW_TEXT);
const [cursor, setCursor] = useState(PROMPT_PREVIEW_TEXT.length);
const onChange = useCallback((nextValue: string, nextCursor: number) => {
const onChange = (nextValue: string, nextCursor: number) => {
setPrompt(nextValue);
setCursor(nextCursor);
}, []);
};
return (
<div className="mt-1 mb-2 rounded-lg border border-border bg-background px-3 py-2">
<ComposerPromptEditor
Expand Down Expand Up @@ -173,6 +173,7 @@ export function TerminalFontPreview({ family, size }: { family: string; size: nu
const surface = surfaceRef.current;
if (!mount || !surface) return;
surface.setTheme(terminalThemeFromApp(mount));
// oxlint-disable-next-line react/exhaustive-effect-dependencies -- The tokens come from the DOM's computed styles, which a theme change rewrites.
}, [theme, resolvedTheme]);

useEffect(() => {
Expand Down
Loading