Skip to content

refactor(web): the pull request thread dialog keeps its caching without "use memo" hooks #20742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 17, 2026
Merged

refactor(web): the pull request thread dialog keeps its caching without "use memo" hooks #20742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions apps/web/src/components/PullRequestThreadDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,6 @@ interface PullRequestThreadDialogProps {
onPrepared: (input: { branch: string; worktreePath: string | null }) => Promise<void> | void;
}

// The prepare action keys on this scope, and the compiler would rebuild it every
// render because hooks run after it.
function useSourceControlScope(environmentId: EnvironmentId, cwd: string | null) {
"use memo";
return { environmentId, cwd };
}

function pullRequestStatusTone(state: string | undefined): string {
switch (state) {
case "merged":
Expand Down Expand Up @@ -108,17 +101,19 @@ export function PullRequestThreadDialog({

const parsedReference = parsePullRequestReference(reference);
const parsedDebouncedReference = parsePullRequestReference(debouncedReference);
const sourceControlScope = useSourceControlScope(environmentId, cwd);
const pullRequestResolution = usePullRequestResolution({
...sourceControlScope,
environmentId,
cwd,
reference: open ? parsedDebouncedReference : null,
});
const cachedPullRequest =
readCachedPullRequestResolution({
...sourceControlScope,
environmentId,
cwd,
reference: parsedReference,
})?.pullRequest ?? null;
const preparePullRequestThreadAction = usePreparePullRequestThreadAction(sourceControlScope);
// The prepare action keys on this scope object, so it only ever reaches the hook.
const preparePullRequestThreadAction = usePreparePullRequestThreadAction({ environmentId, cwd });
const canOperateThread = useEnvironmentScope(environmentId, AuthOrchestrationOperateScope);

const liveResolvedPullRequest =
Expand Down
Loading