Repository navigation
fix(bitbucket): show mention names without changing editable source - #21648
Open
juliusmarminge wants to merge 3582 commits into
Open
juliusmarminge wants to merge 3582 commits into
juliusmarminge wants to merge 3582 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilt from @0pilatos0’s #14787, which identified the same-object Bitbucket mention metadata and the need to keep editable Markdown intact.
Bitbucket descriptions and comments show account IDs instead of names. Read labels only from the same response object's rendered mention metadata, and substitute prose tokens in optional display fields. Preserve exact authored text outside those ranges, including code, links, escapes, and HTML. Missing or conflicting metadata falls back to raw text; no account lookup or setting is added.
Web/desktop Summary, Timeline and Code readers and the corresponding mobile readers consume display fields. Editors, outgoing writes, drafts and agent context retain raw source. Native diff rows use a paired plain display string, avoiding Markdown conversion that lost authored source. Depends on #21647.
Verification:
Before (actual pinned main) and after (current stack head), same fixture, 1280×800, same viewport and scroll. Both captures use a page-only font substitution because this browser has no fallback fonts; no font/product changes are in the diff.
Edit/cancel/save recording · Captured raw save payloads
The API fixture is synthetic: live Bitbucket Cloud metadata, including rendered description fields and ap-mention attributes, still needs verification with a real account. No runtime verification on macOS, Windows, iOS, Android, Electron desktop, or real remote/relay/tunnel connections. Mobile has type and focused logic coverage only. Human approval of the cross-layer parser/contract change remains required. Unmerged.
Implemented in T3 Code with Codex gpt-6-astra (tests), gpt-6.1-sol (implementation), and Claude claude-opus-5-5 / Codex gpt-6-sol (review).
Fixes #14771