Repository navigation
fix(server): show self-resumed Claude subagents as running #23831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juliusmarminge
wants to merge
11
commits into
main
Choose a base branch
from
fix/issue-16610
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+232
−19
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7cc3627
test(server): reproduce a completed Claude subagent not reopening on …
juliusmarminge 97f4d6c
fix(server): a completed Claude subagent that resumes while the root …
juliusmarminge 7bc4ed4
fix(server): a Claude subagent that resumes itself while the root is …
juliusmarminge 1f20a8c
fix(server): drop the unneeded idle-root settle gate from the subagen…
juliusmarminge d6a049d
test(server): preserve the Claude self-resume runtime scenario
juliusmarminge 3d80b6f
Merge main into fix/issue-16610
juliusmarminge acb547d
chore: follow namespace imports in the self-resume fixture
juliusmarminge b99b2da
chore: register the self-resume fixture entry point
juliusmarminge 74c7c77
Merge main into fix/issue-16610
juliusmarminge 72c7648
Merge remote-tracking branch 'origin/main' into fix/issue-16610
juliusmarminge 0db46bf
test(server): provide crypto to the self-resume test and drop the liv…
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness |
Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: pingdotgg/t3code
Length of output: 1706
🏁 Script executed:
Repository: pingdotgg/t3code
Length of output: 35893
🏁 Script executed:
Repository: pingdotgg/t3code
Length of output: 43474
🏁 Script executed:
Repository: pingdotgg/t3code
Length of output: 43367
🏁 Script executed:
Repository: pingdotgg/t3code
Length of output: 7161
Reopen the registry entry only when the launch
tool_use_idmatches.The
Ref.modifycall reopens every known terminal subagent that receivestask_started, includingSendMessageresumes with a differenttool_use_id. Although that path returnsfalse, it still changes the registry entry torunning, preserves the oldrunId, and makes background-work checks report active work.If the wake buffer is cleared before the normal
task_startedbranch runs, the registry remainsrunningwhile the UI remains completed. Query-exit finalization can then mark the child as failed or cancelled.Proposed fix
📝 Committable suggestion