Skip to content

fix(server): browser load errors with digits keep their full name #24244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 1 commit into from
Oct 30, 2026
Merged

fix(server): browser load errors with digits keep their full name #24244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions apps/server/src/preview/ServerBrowserPage.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,3 +287,17 @@ describe("server browser drag", () => {
}
});
});

describe("server browser net errors", () => {
it.each([
["net::ERR_CONNECTION_REFUSED", "ERR_CONNECTION_REFUSED", -102],
[
"page.goto: net::ERR_HTTP2_PROTOCOL_ERROR at https://localhost:5173/",
"ERR_HTTP2_PROTOCOL_ERROR",
-2,
],
["net::ERR_TLS13_DOWNGRADE_DETECTED", "ERR_TLS13_DOWNGRADE_DETECTED", -2],
])("reads the whole error name from %j", (errorText, description, code) => {
expect(ServerBrowserPage.parseNetError(errorText)).toEqual({ description, code });
});
});
3 changes: 2 additions & 1 deletion apps/server/src/preview/ServerBrowserPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,7 +918,8 @@ const NET_ERROR_CODES: Readonly<Record<string, number>> = {
};

export const parseNetError = (errorText: string) => {
const description = /ERR_[A-Z_]+/.exec(errorText)?.[0] ?? errorText;
// Names can hold digits, as in ERR_HTTP2_PROTOCOL_ERROR.
const description = /ERR_[A-Z\d_]+/.exec(errorText)?.[0] ?? errorText;
return { description, code: NET_ERROR_CODES[description] ?? -2 };
};

Expand Down
Loading