Repository navigation
fix: settle and snooze threads while their machine is offline #24917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shivamhwp
wants to merge
62
commits into
main
Choose a base branch
from
issue-watch/24532
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,503
−140
Open
Changes from all commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
2534ffb
fix: settle and snooze threads while their environment is offline
49d939a
fix: keep offline settle and snooze safe across replay, removal, and …
2d3a411
fix: keep removed environments out of offline triage loads, and enabl…
b930245
test(web): update thread action fixtures for offline triage
5bdf5fb
fix: decide queued settle Undo when it runs, and keep removed grants …
f806de2
fix: let web triage pass the offline grant, queue the acted-on snapsh…
e6c9ed5
fix(web): show Pending on a snoozed row waiting to sync
e88b63b
fix: drop the queued change a newer action replaced after its replay …
8f4d880
fix(web): keep the orchestration command hook compilable by React Com…
60daf54
fix: check shared storage before replaying a queued settle or snooze
c24f97a
fix: judge expiry on the replayed change and stop replay with its reg…
d6f1350
fix(client-runtime): replay triage queued during reconnect
5c73439
fix: let the server undo a queued change that may already have landed
2092c65
fix: keep the sent mark when a queued change is replaced
1500acc
fix: read and mark a replayed change in one storage step
cc47398
fix(mobile): restore snooze during offline settle undo
7f8fc82
fix: serialize the offline queue across tabs and replay after a faile…
c18be0f
fix(web): reject offline queue writes without a shared lock
c107bb6
refactor(web): hold the offline queue's Web Lock on the caller's fiber
dfdc648
fix(web): cancel pending offline queue lock requests
ca72a3f
fix(web): release queue locks granted after cancellation
f501590
Merge remote-tracking branch 'github/main' into issue-watch/24532
maria-rcks ad600b0
fix(client): guard offline triage through reconnect and undo
maria-rcks a073ca7
chore: merge main into offline thread triage
maria-rcks 76d097c
fix(client): load the full triage outbox before reconnect refresh
maria-rcks 820631b
chore: merge main into offline thread triage
maria-rcks 3eeb368
Merge remote-tracking branch 'origin/main' into issue-watch/24532
83d9f4d
fix(web): queue offline settle and snooze on plain HTTP too
5bc76a9
refactor(web): build the outbox storage error where it fails
2d21e1f
fix(server): a stopped provider session no longer drops queued settle…
1c3f425
Merge remote-tracking branch 'origin/main' into issue-watch/24532
55c8f98
fix(web): Pending outranks a folder row's status and wake label
24659c5
fix(client): settle and snooze during reconnect still work against ol…
27cb024
Merge remote-tracking branch 'origin/main' into issue-watch/24532
776b48a
merge: sync offline triage with main
maria-rcks 43d7f19
Merge remote-tracking branch 'origin/main' into issue-watch/24532
89b7646
Merge remote-tracking branch 'origin/main' into issue-watch/24532
a2d6dfd
Merge remote-tracking branch 'origin/main' into issue-watch/24532
70c1d76
merge: sync offline thread triage with main
maria-rcks d9d74d0
fix(client): say why snooze is refused while a settle waits to sync
shivamhwp c360472
Merge remote-tracking branch 'origin/main' into issue-watch/24532
shivamhwp 2cc00a9
fix(client): offline, un-settle and wake need a change waiting to sync
shivamhwp 75356c7
Merge remote-tracking branch 'origin/main' into issue-watch/24532
shivamhwp 22139fb
fix(mobile): keep the environment-cleanup error catch after merging main
shivamhwp 9463c54
Merge remote-tracking branch 'origin/main' into issue-watch/24532
shivamhwp f3ba024
refactor(client-runtime): simplify the offline triage queue
shivamhwp dbe264f
fix(client-runtime): stop replay storms and late writes after removal
shivamhwp 881b7df
test(client-runtime): prove replay never sends a change it could not …
shivamhwp aa82609
fix(client-runtime): leave a change unmarked when the server cannot r…
shivamhwp 28f69a9
fix(web,mobile): announce pending sync and keep outbox logs bounded
shivamhwp 3c13184
Merge remote-tracking branch 'origin/main' into issue-watch/24532
shivamhwp 0a9cd75
refactor: queue offline settle and snooze on the client only
shivamhwp fca9be5
chore: merge main into offline thread triage
maria-rcks 23becb7
Merge remote-tracking branch 'origin/issue-watch/24532' into issue-wa…
shivamhwp 0ab8f18
fix(client-runtime): judge queued changes at send time and by every t…
shivamhwp 80d5595
fix(client-runtime): replay reads the stored queue and marks only whi…
shivamhwp b2f589c
fix(client-runtime): a change whose send never left the device stays …
shivamhwp 37d7698
fix(client-runtime): a disconnect while a change is marked leaves it …
shivamhwp 285a9bd
fix(client-runtime): replay only takes off a sent mark it made itself
shivamhwp 5bc9fda
fix(client-runtime): retry reading the offline queue after a failed f…
shivamhwp 64b8f90
Merge remote-tracking branch 'github/main' into issue-watch/24532
maria-rcks 6c3c886
Merge remote-tracking branch 'github/main' into issue-watch/24532
maria-rcks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.