Skip to content

chore(lint): disable returnEffectInGen #25050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 26, 2026
Merged

chore(lint): disable returnEffectInGen #25050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/server/src/observability/EventLoopMonitor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ const makeNodeSampler = Effect.gen(function* () {
let usage = process.resourceUsage();
let sampledAt = NodePerfHooks.performance.now();

// @effect-diagnostics-next-line returnEffectInGen:off - the read effect is the result.
return Effect.sync(() => {
const nextElu = NodePerfHooks.performance.eventLoopUtilization();
const nextUsage = process.resourceUsage();
Expand Down
1 change: 0 additions & 1 deletion apps/server/src/orchestration-v2/LiveStreamBudget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,6 @@ export const makeLiveStreamBudget = Effect.fn("makeLiveStreamBudget")(function*
}),
Effect.forkScoped,
);
// @effect-diagnostics-next-line returnEffectInGen:off - Stream.fromPull needs the pull effect as its result.
return Effect.gen(function* () {
// RpcServer requests the next batch after ACK; dequeueing does not end delivery.
release(inFlight);
Expand Down
1 change: 0 additions & 1 deletion apps/server/src/orchestration-v2/ShellStream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,6 @@ export function composeShellStreamWithEnrichment<A, E, R, A2, E2, R2, A3, E3, R3
let previous: Deferred.Deferred<void> | undefined;
// Stream.merge pulls ahead after handing off each batch. Wait for the next
// downstream pull so shell delivery keeps that batch charged until its RPC ACK.
// @effect-diagnostics-next-line returnEffectInGen:off - Stream.fromPull needs the pull effect as its result.
return Effect.gen(function* () {
if (previous) yield* Deferred.succeed(previous, undefined);
const next = yield* Queue.take(output);
Expand Down
1 change: 0 additions & 1 deletion apps/server/src/ws.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3366,7 +3366,6 @@ export const layer = Layer.unwrap(
),
Effect.forkScoped,
);
// @effect-diagnostics-next-line returnEffectInGen:off
return httpEffect;
}).pipe(
Effect.provide(
Expand Down
1 change: 0 additions & 1 deletion infra/relay/src/hooks/HookInboxObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ export const layer = HookInboxObject.make(
Effect.gen(function* () {
const state = yield* Cloudflare.DurableObjectState;
// Only the per-object inner Effect may access storage.
// @effect-diagnostics-next-line returnEffectInGen:off
return Effect.gen(function* () {
const layerSql = SqliteClient.layer({ storage: state.raw.storage });
const inboxId = state.raw.id.name ?? state.raw.id.toString();
Expand Down
1 change: 1 addition & 0 deletions tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
"flatMapIgnoredParamToAndThen": "error",
"mapSomeToAsSome": "error",
"unnecessaryPipeChain": "error",
"returnEffectInGen": "off",
"effectFnOpportunity": "suggestion",
"anyUnknownInErrorContext": "error",
"unsafeEffectTypeAssertion": "error",
Expand Down
Loading