chore(lint): enforce catchToOrElseSucceed

apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts

@@ -2985,7 +2985,7 @@ export const makeCodexAdapterV2 = Effect.fn("makeCodexAdapterV2")(function* (
                         }
                       : null,
                   ),
-                  Effect.catch(() => Effect.succeed(null)),
+                  Effect.orElseSucceed(() => null),
                   Effect.flatMap((response) =>
                     response === null
                       ? client.raw

apps/server/src/preview/ServerBrowserStream.ts

@@ -206,7 +206,7 @@ const makeHandler = Effect.fnUntraced(function* (browser: ServerBrowser.ServerBr
           Effect.as(HttpServerResponse.text("Service Unavailable", { status: 503 })),
         ),
     }),
-    Effect.catch(() => Effect.succeed(HttpServerResponse.empty())),
+    Effect.orElseSucceed(() => HttpServerResponse.empty()),
   );
 });
 

apps/server/src/workspace/WorkspaceFileSystem.ts

@@ -167,8 +167,7 @@ export const make = Effect.gen(function* () {
           }
         },
         catch: () => undefined,
-        // @effect-diagnostics-next-line effectSucceedWithVoid:off - This optional result requires undefined, not the wider void type.
-      }).pipe(Effect.catch(() => Effect.succeed(undefined)));
+      }).pipe(Effect.orElseSucceed(() => undefined));
     }
     return {
       kind: "file",

packages/client-runtime/src/state/commandPermissions.ts

@@ -53,7 +53,7 @@ function makeCommandPermissions<R, E>(
             suspendOnWaiting: false,
           }).pipe(
             Effect.timeoutOption(6_000),
-            Effect.catch(() => Effect.succeed(Option.none<AuthSessionState>())),
+            Effect.orElseSucceed(() => Option.none<AuthSessionState>()),
           );
           const missing = scopes.find(
             (scope) => Option.isNone(session) || !sessionGrantsScope(session.value, scope),

packages/provider-cursor/src/server/accountUsage.ts

@@ -355,13 +355,14 @@ export const readCursorAccountUsage = Effect.fn("readCursorAccountUsage")(functi
       duration: Duration.seconds(60),
       orElse: () => invalid("Account usage read timed out"),
     }),
-    Effect.catch(() =>
-      Effect.succeed({
-        accountKey,
-        records: [],
-        missing: false,
-        error: "Cursor account usage could not be read.",
-      } satisfies CursorAccountUsageReadResult),
+    Effect.orElseSucceed(
+      () =>
+        ({
+          accountKey,
+          records: [],
+          missing: false,
+          error: "Cursor account usage could not be read.",
+        }) satisfies CursorAccountUsageReadResult,
     ),
   );
 });

scripts/mobile-native-client.ts

@@ -448,7 +448,7 @@ const remoteCache = Effect.fn("nativeClient.remoteCache")(
       ...login,
     } satisfies RemoteCache;
   },
-  Effect.catch(() => Effect.succeed(null)),
+  Effect.orElseSucceed(() => null),
 );
 
 const authorized = (remote: RemoteCache, request: HttpClientRequest.HttpClientRequest) =>

tsconfig.base.json

@@ -24,6 +24,7 @@
         "namespaceImportPackages": ["@effect/platform-node", "effect"],
         "effectFn": ["span", "inferred-span", "suggested-span"],
         "diagnosticSeverity": {
+          "catchToOrElseSucceed": "error",
           "unnecessaryFailYieldableError": "error",
           "preferSucceedSomeOrNone": "error",
           "effectSucceedWithVoid": "error",