Skip to content

fix(antigravity): binary file reads return an error, not garbled text #25292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 2 commits into from
Oct 30, 2026
Merged

fix(antigravity): binary file reads return an error, not garbled text #25292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce2c85c
fix(antigravity): reject binary client file reads instead of returnin…
only21mil Oct 26, 2026
0ae33dd
fix(antigravity): merge main and preserve binary read validation
maria-rcks Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions apps/server/src/orchestration-v2/Adapters/AntigravityAdapterV2.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,25 @@ describe("AntigravityAdapterV2 client file system", () => {
context("fs/read_text_file"),
);
assert.equal(pasted.content, "pasted");
yield* fileSystem.writeFileString(insidePath, "\uFEFFfirst\né中🙂\nlast");
const sliced = yield* readTextFile(
{ sessionId: "mock-session-1", path: insidePath, line: 2, limit: 1 },
context("fs/read_text_file"),
);
assert.equal(sliced.content, "é中🙂");
yield* fileSystem.writeFileString(insidePath, "inside");
for (const [name, bytes] of [
["image.png", new Uint8Array([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a])],
["data.bin", new Uint8Array([0x61, 0, 0x62])],
] as const) {
const binaryPath = path.join(workspace, name);
yield* fileSystem.writeFile(binaryPath, bytes);
const binaryRead = yield* readTextFile(
{ sessionId: "mock-session-1", path: binaryPath },
context("fs/read_text_file"),
).pipe(Effect.flip);
assert.propertyVal(binaryRead, "code", -32602, `${name} is refused as binary`);
}

const outsideRead = yield* readTextFile(
{ sessionId: "mock-session-1", path: outsideFile },
Expand Down
16 changes: 14 additions & 2 deletions apps/server/src/provider/acp/AntigravityClientFiles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,25 @@ export const readAntigravityClientTextFile = Effect.fn("AntigravityClientFiles.r
`File '${input.request.path}' is not a readable text file under ${CLIENT_FILE_MAX_BYTES} bytes.`,
);
}
const text = yield* input.fileSystem
.readFileString(filePath)
const bytes = yield* input.fileSystem
.readFile(filePath)
.pipe(
Effect.mapError(() =>
EffectAcpErrors.AcpRequestError.internalError(`Could not read '${input.request.path}'.`),
),
);
const text = yield* Effect.try({
try: () => new TextDecoder("utf-8", { fatal: true }).decode(bytes),
catch: () =>
EffectAcpErrors.AcpRequestError.invalidParams(
`File '${input.request.path}' is not a UTF-8 text file.`,
),
});
if (text.includes("\0")) {
return yield* EffectAcpErrors.AcpRequestError.invalidParams(
`File '${input.request.path}' contains binary data.`,
);
}
const line = input.request.line ?? undefined;
const limit = input.request.limit ?? undefined;
if (line === undefined && limit === undefined) {
Expand Down
Loading