Skip to content

perf(mobile): skip unchanged terminal toolbar fade updates #25312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yash-Singh1 merged 3 commits into from
Nov 5, 2026
Merged

perf(mobile): skip unchanged terminal toolbar fade updates #25312

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bf3158
perf(mobile): skip unchanged terminal toolbar fade updates
saphid Oct 26, 2026
372c9d9
fix(mobile): integrate reviewed optimization with current main
github-actions[bot] Oct 29, 2026
b17e917
Merge commit '961026c6c98118a5017888a8cb6ed7078db140eb' into ready/mo…
saphid Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 46 additions & 24 deletions apps/mobile/src/components/ComposerToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { ComponentProps, ReactNode } from "react";
import { useState } from "react";
import { useCallback, useRef, useState } from "react";
import {
Pressable,
ScrollView,
Expand Down Expand Up @@ -148,37 +148,59 @@ export function ComposerToolbarScroller(props: {
readonly fadeSurface?: "card" | "sheet";
readonly contentPaddingRight?: number;
}) {
const [metrics, setMetrics] = useState({
const metricsRef = useRef({
contentWidth: 0,
offsetX: 0,
viewportWidth: 0,
showLeftFade: false,
showRightFade: false,
});
const [scrollEdges, setScrollEdges] = useState({
showLeftFade: false,
showRightFade: false,
});

const maxOffset = Math.max(0, metrics.contentWidth - metrics.viewportWidth);
const scrollEdges = {
showLeftFade: metrics.offsetX > COMPOSER_TOOLBAR_SCROLL_EPSILON,
showRightFade: metrics.offsetX < maxOffset - COMPOSER_TOOLBAR_SCROLL_EPSILON,
};
const updateScrollEdges = useCallback(() => {
const metrics = metricsRef.current;
const maxOffset = Math.max(0, metrics.contentWidth - metrics.viewportWidth);
const showLeftFade = metrics.offsetX > COMPOSER_TOOLBAR_SCROLL_EPSILON;
const showRightFade = metrics.offsetX < maxOffset - COMPOSER_TOOLBAR_SCROLL_EPSILON;
if (metrics.showLeftFade === showLeftFade && metrics.showRightFade === showRightFade) {
return;
}
metrics.showLeftFade = showLeftFade;
metrics.showRightFade = showRightFade;
setScrollEdges({ showLeftFade, showRightFade });
}, []);

const handleLayout = (event: LayoutChangeEvent) => {
const viewportWidth = event.nativeEvent.layout.width;
setMetrics((current) =>
current.viewportWidth === viewportWidth ? current : { ...current, viewportWidth },
);
};
const handleLayout = useCallback(
(event: LayoutChangeEvent) => {
const viewportWidth = event.nativeEvent.layout.width;
if (metricsRef.current.viewportWidth === viewportWidth) return;
metricsRef.current.viewportWidth = viewportWidth;
updateScrollEdges();
},
[updateScrollEdges],
);

const handleContentSizeChange = (contentWidth: number) => {
setMetrics((current) =>
current.contentWidth === contentWidth ? current : { ...current, contentWidth },
);
};
const handleContentSizeChange = useCallback(
(contentWidth: number) => {
if (metricsRef.current.contentWidth === contentWidth) return;
metricsRef.current.contentWidth = contentWidth;
updateScrollEdges();
},
[updateScrollEdges],
);

const handleScroll = (event: NativeSyntheticEvent<NativeScrollEvent>) => {
const offsetX = event.nativeEvent.contentOffset.x;
setMetrics((current) =>
Math.abs(current.offsetX - offsetX) < 1 ? current : { ...current, offsetX },
);
};
const handleScroll = useCallback(
(event: NativeSyntheticEvent<NativeScrollEvent>) => {
const offsetX = event.nativeEvent.contentOffset.x;
if (Math.abs(metricsRef.current.offsetX - offsetX) < 1) return;
metricsRef.current.offsetX = offsetX;
updateScrollEdges();
},
[updateScrollEdges],
);

return (
<View className="relative min-w-0 flex-1">
Expand Down
Loading