Skip to content

fix(prs): classify generated files and evals correctly #26563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 3 commits into from
Oct 30, 2026
Merged

fix(prs): classify generated files and evals correctly #26563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf6ce6e
fix(prs): classify generated files and evals correctly
jakeleventhal Oct 28, 2026
0ff8fbd
fix(prs): classify eval files across extensions
jakeleventhal Oct 28, 2026
6c86390
test(prs): keep one case per classification behavior
jakeleventhal Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/shared/src/changedFileKind.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ describe("classifyChangedFile", () => {
["src/contest.py", "code"],
["test/fixtures/pr.json", "mocks"],
["pnpm-lock.yaml", "generated"],
["convex/_generated/api.d.ts", "generated"],
["src/agent.eval.ts", "tests"],
["evals/title-generation.ts", "tests"],
["README.md", "docs"],
["tests/README.md", "tests"],
] as const)("%s is %s", (path, kind) => {
Expand Down
5 changes: 3 additions & 2 deletions packages/shared/src/changedFileKind.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const GENERATED_FILES = new Set([
]);
const GENERATED_NAME =
/(\.generated\.|\.gen\.|\.g\.dart$|\.pb\.go$|_pb2(_grpc)?\.py$|\.pb\.(cc|h)$|\.min\.(js|css)$|\.(js|css)\.map$)/;
const GENERATED_DIRS = new Set(["__generated__", "generated"]);
const GENERATED_DIRS = new Set(["__generated__", "_generated", "generated"]);

const MOCK_NAME =
/(\.snap$|\.(mocks?|fixtures?|stubs?|fakes?)\.[^.]+$|^(mocks?|fixtures?|stubs?|fakes?)([-_.A-Z]|$))/;
Expand All @@ -44,14 +44,15 @@ const MOCK_DIRS = new Set([
]);

const TEST_NAME =
/(\.(test|spec|e2e)\.[^.]+$|_(test|spec)\.[^.]+$|^test_.+\.py$|^conftest\.py$|^(vitest|jest)\.setup\.[^.]+$)/i;
/(\.(test|spec|e2e|eval)\.[^.]+$|_(test|spec)\.[^.]+$|^test_.+\.py$|^conftest\.py$|^(vitest|jest)\.setup\.[^.]+$)/i;
// Case-sensitive: `FooTest.java` is a test class, `Latest.java` is not.
const CLASS_TEST_NAME = /(Tests?|Spec)\.(java|kt|kts|scala|groovy|cs|php|swift|m)$/;
const TEST_DIRS = new Set([
"__tests__",
"__test__",
"cypress",
"e2e",
"evals",
"spec",
"specs",
"test",
Expand Down
Loading