Repository navigation
fix(web): prevent long markdown links from flooding the DOM - #26827
Closed
saimircelaj0 wants to merge 1 commit into
Closed
saimircelaj0 wants to merge 1 commit into
saimircelaj0 wants to merge 1 commit into
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Long Markdown link labels now use CSS wrapping instead of per-character DOM elements, reducing DOM growth. The change is confined to presentation and leaves link destinations and actions unchanged. You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A long raw URL can make the desktop UI stall on clicks.
MarkdownExternalLinkContentinserts a<wbr>after every character in each long word. A macOS 0.1.3 trace showed roughly four-second main-thread commits with one such link mounted; removing and restoring the link removed and restored the load.Render each long word in one inline span with
overflow-wrap: anywhereinstead. Keep short words intact, preserve the unbroken protocol/favicon prefix, and preserve the full text, destination, and rich children. This is a small, focused obvious-bug fix under CONTRIBUTING's prior-issue exception: it removes the unbounded element expansion without adding a feature or changing link actions.Validation:
vp run check:changedpassed format, lint, knip, affected-package typechecks, and both browser tests.The screenshots and short recordings below use synthetic data. They demonstrate preserved rendering and interaction, not a controlled before/after latency benchmark. Private traces and real conversations are not included.
Before recording · After recording
Implemented with GPT-6.1 Sol through the Codex harness in T3 Code.