Repository navigation
fix(mobile): the thread no longer bounces when a reply finishes - #28334
Draft
hryhoriiK97 wants to merge 2 commits into
Draft
hryhoriiK97 wants to merge 2 commits into
hryhoriiK97 wants to merge 2 commits into
Conversation
Sending with the keyboard open overlapped the new bubble with other rows and could blank the history for a few frames, because the keyboard close, the list's end pin and the row's slide-up all moved at once. The list now stops following the end while the keyboard closes, then pins once, and the sent row only fades. The close and the end pin take turns in thread-end-repin.ts, since a pin freezes the keyboard's inset updates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When a turn ended, the list scrolled down with the shrinking floating status inset, then jumped back up as the reply's footer row appeared. The list now holds its position while that inset collapses, then pins to the end once. It skips the freeze while the keyboard is up or moving, because a frozen list misses keyboard inset events. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
vouch:unvouched
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #28333. I can't push a branch upstream, so this targets
mainand also shows that PR's commit. Review only the top commit,fix(mobile): the thread no longer bounces when a reply finishes.When a turn ends in the mobile app, the thread bounces. The list scrolls down with the shrinking floating status inset, then jumps back up as the reply's footer row appears.
The fix holds the list in place while that inset collapses, then pins to the end once. It skips the freeze while the keyboard is up or moving, because a frozen list misses keyboard inset events.
Evidence
iOS simulator, iPhone 18 Pro, slowed 4x. On the left is #28333 alone, and on the right is this commit on top. On the left the reply's last row overshoots and comes back down. On the right it only moves up.
Real-time clips, each a send and a full reply:
main, #28333 alone, this commit. They ran on an isolated server with a scripted provider.What I checked
vp run check:changedpasses.Why this is a draft
Model: Claude Opus 5.5. Harness: Claude Code in T3 Code.
🤖 Generated with Claude Code