Repository navigation
fix(web): thread details slides in on close - #28929
Claudesaul wants to merge 3 commits into
Conversation
Closing the right panel swapped the header's toggle for the title bar's one, so it jumped across the window on the first frame. It now slides from where the header's toggle sat, on the panel's own curve and duration.
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — The change smooths the thread-details toggle’s movement when the right panel closes. It also adds a line-level lint suppression in PanelLayoutControls.tsx:191, which requires human review. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
# Conflicts: # apps/web/src/components/chat/PanelLayoutControls.tsx
Problem
Closing the right panel makes the thread details button jump about 475px across the window on the first frame, while the panel edge is still far away. Opening doesn't do this: the button rides the edge of the chat.
Change
The chat header and the window's top right each have their own copy of this button, and closing swaps one for the other. The top right one now starts where the header's sat and slides into its slot, on the panel's own timing, so it travels with the closing edge.
Scope and approval
Small fix for an obvious jump. What the button does hasn't changed.
Verification
vp test run apps/web/src/components/chat(598 passed); web typecheck and lint clean.Recording: a few opens and closes at regular speed, then one close and open zoomed in at quarter speed. Both sides include the panel fix from #28922, so only this change differs.
Model: Claude Opus 5.5; harness: T3 Code.