Repository navigation
fix(server): Antigravity sign-in no longer blames the network when the runtime never starts #29057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+61
−18
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
562c9ef
test(server): reproduce #29039 Antigravity sign-in blaming the networ…
juliusmarminge ef554ff
fix(server): Antigravity sign-in no longer blames the network when th…
juliusmarminge 06cc12d
Merge remote-tracking branch 'origin/main' into fix/issue-29039
juliusmarminge 1fa7779
Merge origin/main into fix/issue-29039
juliusmarminge 1e84372
Merge remote-tracking branch 'origin/main' into fix/issue-29039
juliusmarminge c61dbe4
chore(server): note why the Antigravity startup hint exists
juliusmarminge 86586c5
Merge branch 'main' into fix/issue-29039
juliusmarminge 08b53f8
Merge branch 'main' into fix/issue-29039
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: pingdotgg/t3code
Length of output: 11639
Script executed:
Repository: pingdotgg/t3code
Length of output: 18107
Script executed:
Repository: pingdotgg/t3code
Length of output: 14422
Identify the unanswered runtime at 30 seconds.
The initial status is already neutral. If initialization does not answer, it remains unchanged until the 90-second warning. At 30 seconds, say that the runtime has not responded yet. Keep the 90-second stuck warning for slow Windows startup, and clear the startup status when initialization succeeds.
Suggested fix
function* (flow: AuthFlow, stopSessions: Effect.Effect<void, ProviderSetupError>) { + const startupWaitHint = yield* publishStartingHint( + flow, + STARTUP_WAIT_HINT_MS, + STARTUP_WAIT_MESSAGE, + ); yield* stopSessions.pipe(Effect.ensuring(stopOwnedProcesses)); const runtime = yield* options.makeRuntime({ onAuthorizationUrl: (url) => receiveAuthorizationUrl(flow, url), }); const startupHint = yield* publishStartingHint(flow, STARTUP_HINT_MS, NOT_STARTED_MESSAGE); // `start` reuses this memoized handshake. yield* runtime.initialize(); flow.initialized = true; + yield* Fiber.interrupt(startupWaitHint); yield* Fiber.interrupt(startupHint); + yield* lock.withPermits(1)( + Effect.gen(function* () { + if ( + activeFlow !== flow || + flow.state.phase !== "starting" || + (flow.state.message !== STARTUP_WAIT_MESSAGE && + flow.state.message !== NOT_STARTED_MESSAGE) + ) return; + yield* publishFlow(flow, { + ...flow.state, + message: usesBrowser ? "Starting Google sign-in." : "Checking credentials.", + }); + }), + ); yield* publishStartingHint(flow, NO_RESPONSE_HINT_MS, NO_RESPONSE_MESSAGE);Extend the existing stalled-initialization test to check both the 30-second status and the 90-second warning.