Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/provider-pi/src/server/adapter.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1533,7 +1533,10 @@ describe("PiAdapterV2", () => {
it.effect("gives notify and extension-error items distinct ids in each thread", () =>
Effect.gen(function* () {
const itemIds = new Set<string>();
for (const threadId of [THREAD_ID, ThreadId.make("thread-pi-test-2")]) {
for (const [threadId, extensionPath] of [
[THREAD_ID, "/ext/a.ts"],
[ThreadId.make("thread-pi-test-2"), "/ext/a/index.ts"],
] as const) {
const fake = yield* makeFakePi;
const { runtime, takeEvent } = yield* openRuntime(fake, "default", threadId);
const providerThread = yield* runtime.ensureThread({
Expand All @@ -1558,14 +1561,17 @@ describe("PiAdapterV2", () => {
method: "notify",
message: "note",
});
yield* fake.emit({ type: "extension_error", extensionPath: "/ext/a.ts", error: "boom" });
yield* fake.emit({ type: "extension_error", extensionPath, error: "boom" });
for (const prefix of ["notify:", "extension-error:"]) {
const item = yield* takeEvent(
(event) =>
event.type === "turn_item.updated" &&
event.turnItem.nativeItemRef?.nativeId?.startsWith(prefix) === true,
);
if (item.type === "turn_item.updated") itemIds.add(item.turnItem.id);
if (item.type === "turn_item.updated" && prefix === "extension-error:") {
assert.equal(item.turnItem.title, "a");
}
}
}
assert.equal(itemIds.size, 4);
Expand Down
6 changes: 4 additions & 2 deletions packages/provider-pi/src/server/adapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3375,8 +3375,10 @@ function piSubagentOutput(result: unknown): string {

function piExtensionDisplayName(extensionPath: string | undefined): string {
if (extensionPath === undefined) return "Pi extension";
const normalized = extensionPath.replace(/\\/g, "/").replace(/\/+$/, "");
const name = normalized.slice(normalized.lastIndexOf("/") + 1).replace(/\.[^.]+$/, "");
const segments = extensionPath.replace(/\\/g, "/").split("/").filter(Boolean);
const fileName = segments.at(-1)?.replace(/\.[^.]+$/, "") ?? "";
// Pi loads a directory extension from its index file; the folder names it.
const name = fileName === "index" ? (segments.at(-2) ?? fileName) : fileName;
return name.length === 0 ? "Pi extension" : name;
}

Expand Down
Loading