Skip to content

fix(web): a scheduled task with a cleared run time no longer saves as 09:00 #29870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saphid wants to merge 3 commits into
base: main
Choose a base branch
from
+13 −1
Open

fix(web): a scheduled task with a cleared run time no longer saves as 09:00 #29870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89db860
fix(web): a scheduled task with a cleared run time no longer saves as…
saphid Nov 3, 2026
0af87c2
Merge remote-tracking branch 'upstream/main' into fix/silentfallback
github-actions[bot] Nov 8, 2026
bcea0b0
merge: retain both scheduled task time regressions
github-actions[bot] Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions apps/web/src/components/settings/scheduledTasksSettings.logic.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,16 @@ describe("fixed-time scheduled tasks", () => {
});
expect(draft.timeOfDay).toBe("09:05");
});

it("keeps a fixed run time and rejects a cleared one", () => {
const draft = taskToDraft({
...legacyTask,
schedule: { type: "fixed_time", timeOfDay: "14:30" },
});
expect(scheduleFromDraft(draft)).toEqual({ type: "fixed_time", timeOfDay: "14:30" });
// A native time input reports "" when it is cleared or only partly filled.
expect(scheduleFromDraft({ ...draft, timeOfDay: "" })).toBeNull();
});
});

describe("scheduled task destination", () => {
Expand Down
4 changes: 3 additions & 1 deletion apps/web/src/components/settings/scheduledTasksSettings.logic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,8 @@ export function scheduleDraftErrors(draft: DraftState) {
];
return [];
}
if (draft.scheduleMode === "fixed" && !draft.timeOfDay)
return [{ title: "Invalid run time", description: "Pick a time." }];
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
if (draft.scheduleMode !== "webhook") return [];
if (parseMaxDeliveryAge(draft.maxDeliveryAgeMinutes) === undefined)
return [
Expand Down Expand Up @@ -233,7 +235,7 @@ export function scheduleFromDraft(draft: DraftState): ScheduledTaskUpsertSchedul
const selectedEveryDay = draft.weekdays.size === 0 || draft.weekdays.size === 7;
return {
type: "fixed_time",
timeOfDay: draft.timeOfDay || "09:00",
timeOfDay: draft.timeOfDay,
...(selectedEveryDay ? {} : { weekdays: [...draft.weekdays].toSorted() }),
};
}
Expand Down
Loading