You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(clients): say "Starting Claude" until the provider actually starts - #30307
When a provider is slow to start, the chat says "Thinking" for as long as it takes, even though nothing is running yet. The server marks a run running before ClaudeAdapterV2.startTurn opens the Claude query, so on a loaded host or behind a long SessionStart hook the label stays wrong for minutes. A Claude registration timeout makes it worse: setMcpServers waits 90s and a resumed session retries once, so "Thinking" can last about 3 minutes before the turn fails. I hit this on a fork whose Claude process never answered: the chat said "Thinking" for almost 2 minutes until I stopped it, and the server log showed orchestration-v2.claude-mcp-registration-timeout with no provider turn.
Change
summarizeThreadRun in client-runtime already marks turnEnded from the run attempt's provider turn. Next to it, a starting or running run with no provider turn yet now carries providerStartingLabel ("Starting Claude", using the session driver's display name). Web and mobile show that label, with a terminal icon, in the live row that says "Thinking". Every adapter reports a provider turn once its turn starts, and Claude reports it after open returns. So the label switches back to "Thinking" as soon as the provider is actually running.
Mobile carries the label on the cached thinking feed entry, and on the latestRunsEqual comparison, so the virtualized feed updates when the provider starts.
Scope and approval
Part of #14244, which Julius triaged as a real chat-surface bug. Its expected behavior is "the UI shows what it is doing (for example 'Starting Claude…')", and the triage notes there is no such string. This PR adds only that label. #23590 is separate: it makes the working row appear during startup at all. This PR changes what the row says once it does appear.
Verification
vp test run packages/client-runtime/src/state/threadExecution.test.ts apps/mobile/src/lib/threadActivity.test.ts: 72 passed. The new case covers a running run with no provider turn ("Starting Claude", or "Starting" with no session) and a running provider turn (no label). With threadExecution.ts reverted, it fails (1 failed, 24 passed).
Typecheck for client-runtime, web, and mobile, plus lint and format on the changed files: clean.
Real web client against an isolated dev server with real Claude (Haiku 5.5). The Claude binary path pointed at a wrapper that sleeps 60s before exec claude for SDK sessions, so T3 waited on setMcpServers exactly as in the report. In the same thread on main, the row said "Thinking". On this branch it said "Starting Claude", then the turn ran normally once Claude started, and the reply "hi" replaced the row.
Before (main)
After
Not checked: the mobile client in a simulator (the change there is the shared run summary plus the label prop), and providers other than Claude in a live run. Every adapter emits provider_turn.updated on turn start, and the label only appears while that turn is missing.
Implementation: Claude Opus 5.5 in Claude Code, running in T3 Code.
The server marks a run running before the provider opens its session. When
the provider is slow to start (a loaded host, a long SessionStart hook, or
Claude's MCP registration wait plus retry), the chat said "Thinking" for
minutes while nothing was running. The run summary now carries a starting
label until the provider reports a turn, and web and mobile show it in
place of "Thinking".
Macroscope's review found this PR approvable — Web and mobile show “Starting” with the provider name until a provider turn appears, then retain the existing activity presentation. This is a display-only change with no change to provider execution or stored data.
You can add or adjust custom eligibility rules. Learn more.
No actionable comments were generated in the recent review.
Walkthrough
Thread run summaries can include a provider-starting label when a run is starting or running without a provider turn. Mobile and web thread activity rows receive and display this label when available.
Changes: Provider startup label
Layer / File(s)
Summary
Derive the provider-starting label packages/client-runtime/src/state/models.ts, packages/client-runtime/src/state/threadExecution.ts, packages/client-runtime/src/state/threadExecution.test.ts
Thread run summaries can include a provider-starting label for starting or running runs without a provider turn. The label uses a matching provider session’s display name when available. Tests cover named and generic labels, and the absence of a label when a provider turn is running.
Carry the label into thread activity apps/mobile/src/lib/threadActivity.ts
Thinking entries and latest-run data can carry the label. Run comparisons and thinking-row caching account for label changes.
Pass and display the label apps/web/src/components/ChatView.tsx, apps/web/src/components/chat/MessagesTimeline.tsx, apps/web/src/components/chat/timelineRowContext.ts, apps/web/src/components/chat/TimelineWorkGroupRows.tsx, apps/mobile/src/features/threads/ThreadFeed.tsx, apps/mobile/src/features/threads/thread-work-log.tsx
The web timeline and mobile thinking row receive the label. When present, a row displays it with a terminal icon; otherwise, the row displays “Thinking” with a brain icon.
The startup label follows provider-turn state on the verified paths. No merge-blocking issue is established.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title clearly summarizes the main change: show “Starting Claude” until the provider starts its turn.
Description check
The description covers the problem, change, scope and approval, and verification. It reports test and live-run results, includes before-and-after screenshots, and states what was not checked.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
Written by gpt-6.1-sol and claude-opus-5-5 on behalf of Maria
Verified in a real dev environment
verified the web path on Linux with repo Playwright and /usr/bin/google-chrome, using real Codex gpt-6.1-sol through the local proxy. created the project and threads through the app against a real git checkout. no mocks, fixtures, demo provider, or artificial startup delay.
reproduced on github/main (9def583f8e315f644708501ebcf1f3d4bb320444): the row said "Thinking" before any provider turn existed.
checked the exact PR head c2948a9f8f5bae047f8f7a38c11ca693e0dff066: the same prompt showed "Starting Codex" with the terminal icon, then "Thinking" after provider-turn registration, then real terminal activity and the completed reply. the live row cleared.
a second turn ran in the same thread. "Stop generation" interrupted the real provider turn, cleared the live row, and showed "Stopped by user". a subsequent message completed successfully.
Blacksmith ran vp test run packages/client-runtime/src/state/threadExecution.test.ts apps/mobile/src/lib/threadActivity.test.ts: 72 passed. the head's 31 CI checks were successful. no code changes needed.
selected persisted server events (UTC), read from the isolated dev databases:
24-second recording (GIF for GitHub compatibility) of submission, startup label, thinking, real command execution, and reply. inspected the recording and verified uploaded playback and seeking in T3's browser:
Not verified
Claude's actual startup/MCP-registration delay: claude auth status reports loggedIn: false, so this verifies the shared label behavior through Codex, not a real Claude session. native iOS/Android and Electron desktop were not exercised on this Linux VM. other provider adapters, remote/relay connections, and upstream model queues were not exercised; the label tracks provider-turn registration, not every upstream queue or network delay.
Merged main (6769598ae0)
merged main with a merge commit. main added the zen live answer preview, which reuses the same Thinking-row label. resolved it so the starting label wins before the provider turn, the zen preview keeps the brain icon, and mobile carries the starting label as its own providerStartingLabel field on the thinking entry. vp run check:changed passed on Blacksmith (format, lint, knip, typecheck, 261 tests, react compiler). the live UI was not rechecked after the merge.
Written by Claude Opus 5.5 (Claude Code in T3 Code) on behalf of Ishaan
Closing the mobile gap from the verification above.
Ran the PR head (6769598ae0) in T3 Code Dev on an iOS 27.2 simulator (iPhone 18 Pro), paired to an isolated dev server with real Claude (Haiku 5.5). As in the web check, the Claude binary path pointed at a wrapper that waits 60s before starting Claude, so the startup window stays open long enough to capture.
While Claude was starting, the live row said "Starting Claude" with the terminal icon.
When the provider turn started (provider-turn.updated running, 61s after run.updated running), it switched to "Thinking" with the brain icon. The reply replaced the row 2s later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:M30-99 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
vouch:unvouched
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Problem
When a provider is slow to start, the chat says "Thinking" for as long as it takes, even though nothing is running yet. The server marks a run
runningbeforeClaudeAdapterV2.startTurnopens the Claude query, so on a loaded host or behind a longSessionStarthook the label stays wrong for minutes. A Claude registration timeout makes it worse:setMcpServerswaits 90s and a resumed session retries once, so "Thinking" can last about 3 minutes before the turn fails. I hit this on a fork whose Claude process never answered: the chat said "Thinking" for almost 2 minutes until I stopped it, and the server log showedorchestration-v2.claude-mcp-registration-timeoutwith no provider turn.Change
summarizeThreadRunin client-runtime already marksturnEndedfrom the run attempt's provider turn. Next to it, astartingorrunningrun with no provider turn yet now carriesproviderStartingLabel("Starting Claude", using the session driver's display name). Web and mobile show that label, with a terminal icon, in the live row that says "Thinking". Every adapter reports a provider turn once its turn starts, and Claude reports it afteropenreturns. So the label switches back to "Thinking" as soon as the provider is actually running.Mobile carries the label on the cached thinking feed entry, and on the
latestRunsEqualcomparison, so the virtualized feed updates when the provider starts.Scope and approval
Part of #14244, which Julius triaged as a real chat-surface bug. Its expected behavior is "the UI shows what it is doing (for example 'Starting Claude…')", and the triage notes there is no such string. This PR adds only that label. #23590 is separate: it makes the working row appear during startup at all. This PR changes what the row says once it does appear.
Verification
vp test run packages/client-runtime/src/state/threadExecution.test.ts apps/mobile/src/lib/threadActivity.test.ts: 72 passed. The new case covers a running run with no provider turn ("Starting Claude", or "Starting" with no session) and a running provider turn (no label). WiththreadExecution.tsreverted, it fails (1 failed, 24 passed).exec claudefor SDK sessions, so T3 waited onsetMcpServersexactly as in the report. In the same thread onmain, the row said "Thinking". On this branch it said "Starting Claude", then the turn ran normally once Claude started, and the reply "hi" replaced the row.main)Not checked: the mobile client in a simulator (the change there is the shared run summary plus the label prop), and providers other than Claude in a live run. Every adapter emits
provider_turn.updatedon turn start, and the label only appears while that turn is missing.Implementation: Claude Opus 5.5 in Claude Code, running in T3 Code.