Skip to content

fix(mobile): Android dictation works with regional preferences set #31030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Nov 6, 2026
+19 −2
Merged

fix(mobile): Android dictation works with regional preferences set #31030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...ription/android/src/main/java/expo/modules/t3voicetranscription/GoogleVoiceTranscriber.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ internal class VoiceTranscriptionException(
cause: Throwable? = null
) : Exception(message, cause)

// ML Kit reports every mode UNAVAILABLE for tags with Unicode extensions, which Android adds
// for regional preferences such as the temperature unit (en-US-u-mu-celsius).
internal fun speechLocale(systemLocale: Locale): Locale = systemLocale.stripExtensions()

private val recognitionModes = listOf(
SpeechRecognizerOptions.Mode.MODE_ADVANCED,
SpeechRecognizerOptions.Mode.MODE_BASIC
Expand Down
4 changes: 2 additions & 2 deletions ...ion/android/src/main/java/expo/modules/t3voicetranscription/T3VoiceTranscriptionModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class T3VoiceTranscriptionModule : Module() {
} else {
withContext(Dispatchers.IO) {
val context = requireNotNull(appContext.reactContext)
val locale = Resources.getSystem().configuration.locales[0]
val locale = speechLocale(Resources.getSystem().configuration.locales[0])
isGoogleVoiceTranscriptionSupported { MlKitSpeechClient(context, locale, it) }
}
}
Expand All @@ -47,7 +47,7 @@ class T3VoiceTranscriptionModule : Module() {
)
}
val context = requireNotNull(appContext.reactContext)
val locale = Resources.getSystem().configuration.locales[0]
val locale = speechLocale(Resources.getSystem().configuration.locales[0])
val mode = prepareGoogleVoiceTranscription { MlKitSpeechClient(context, locale, it) }
mapOf("locale" to locale.toLanguageTag(), "mode" to mode)
}
Expand Down
13 changes: 13 additions & 0 deletions ...ion/android/src/test/java/expo/modules/t3voicetranscription/GoogleVoiceTranscriberTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import com.google.mlkit.genai.common.FeatureStatus
import com.google.mlkit.genai.common.GenAiException
import com.google.mlkit.genai.speechrecognition.SpeechRecognizerOptions
import com.google.mlkit.genai.speechrecognition.SpeechRecognizerResponse
import java.util.Locale
import kotlinx.coroutines.CompletableDeferred
import kotlinx.coroutines.cancelAndJoin
import kotlinx.coroutines.flow.flow
Expand All @@ -14,6 +15,18 @@ import org.junit.Assert.assertTrue
import org.junit.Test

class GoogleVoiceTranscriberTest {
@Test
fun dropsRegionalPreferenceExtensionsFromTheSpeechLocale() {
for ((system, expected) in listOf(
"en-US-u-mu-celsius" to "en-US",
"en-GB-u-fw-mon-mu-celsius" to "en-GB",
"ar-EG-u-nu-latn" to "ar-EG",
"zh-Hant-TW" to "zh-Hant-TW"
)) {
assertEquals(expected, speechLocale(Locale.forLanguageTag(system)).toLanguageTag())
}
}

@Test
fun preservesUtterancesAndTheirSpacingWithoutDuplicatingHypotheses() = runBlocking {
for ((finals, trailing, expected) in listOf(
Expand Down
Loading