Skip to content

fix(web): add consistent settings controls and utility tooltips - #31581

Merged
maria-rcks merged 4 commits into
pingdotgg:maria/redesign/6-workspace-panesfrom
flamboh:t3/redesign-fix-settings-primitives
Nov 10, 2026
Merged

maria-rcks merged 4 commits into
pingdotgg:maria/redesign/6-workspace-panesfrom
flamboh:t3/redesign-fix-settings-primitives

Conversation

@flamboh

@flamboh flamboh commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Fix for the redesign stack, targets layer 1 (#28839).

Note

🤖 GPT-6.1 Sol on behalf of Oliver

Settings rows mix recessed fields with raised selects and several control heights. The scope breadcrumb inherits the tab's 320 px cap, and moving between sidebar utility icons restarts each tooltip delay.

Add opt-in well selects, a settings Input size and compact NumberField size with a 28 px outer height, plus an uncapped breadcrumb variant. Share the tooltip provider across Settings, Pull Requests and Usage. Settings model-picker controls use the same well surface and height; composer toolbar controls keep their look. The Thread details menu now uses the same 28 px well SelectButton as other settings controls. Snapshot sound, per-checkout grouping and source-control account selects use compact wells too; telemetry endpoint fields use the settings Input height. Existing primitive defaults remain unchanged; other settings and breadcrumb consumers are in companion layer drafts.

The settings surface is a taste call for Maria: raised versus well. This proposes well in settings rows only; capture both looks for comparison.

Before / after

What to look for: before, the Thread details dropdown has a raised surface; after, it uses the recessed well surface and the same 28 px height as other compact settings controls.

Thread details row before and after, with the control outlined

Captured at 900 px in the light theme, with both menus closed and unfocused. This compares the existing draft before the control fix with its updated head; the Thread details control on that before ref matches layer 1. The new account, grouping, endpoint and disabled Snapshot variants were not separately captured.

Before (layer 1) After
Left side of each utility-hover video Right side of each utility-hover video

What to look for: before, moving between Settings, Pull Requests and Usage restarts each tooltip delay; after, the next utility tooltip appears without restarting the delay.

Normal speed:

https://gh-file-drop-api-prod-galwoqjslzlnws6s.oliver-boorstein.workers.dev/f/0f2453999d9b3ed1/utility-normal.mp4

What to look for: before, each utility tooltip makes you wait again; after, help follows the pointer between utility icons.

Tooltip transitions slowed 4×; hover timing remains normal.

https://gh-file-drop-api-prod-galwoqjslzlnws6s.oliver-boorstein.workers.dev/f/235a8bbd7dca7a66/utility-slow.mp4

The additive controls below compare layer 6 with the combined companion draft in #31598, which carries #31581, #31583, and #31588. These show the controls with their settings consumers applied, rather than the layer-1 head alone. Ember dark, matching viewport and scale in each row.

Before (layer 6) After
Raised selects and mixed field heights Combined drafts with compact well controls

What to look for: before, Snooze mixes raised selects with wells and wraps summaries unevenly; after, the controls share well surfaces and compact rows.

Snooze controls at 1280 and 900 pixels

What to look for: before, font-size selects are raised beside recessed font fields; after, both use well surfaces.

Appearance font fields at 1280 and 900 pixels

What to look for: before, Worktree location uses a taller field; after, it uses the compact settings field.

Worktree location at 1280 and 900 pixels

What to look for: before, Branch prefix uses a taller field; after, it matches the compact settings controls.

Worktree branch prefix at 1280 and 900 pixels

What to look for: before, Custom words uses an input taller than Add; after, the field and action align at the compact height.

Voice custom words at 1280 and 900 pixels

What to look for: before, the Providers breadcrumb truncates the page name and long scope early; after, it preserves the page name and uses the available header width.

Providers breadcrumb at 1280, 900 and 390 pixels

The Providers comparison uses the same long environment-label fixture in both headers. No real-provider turns were sent.

Capture spec: compare the layer 1 base with this head for the footer utility hover sequence. For the additive variants, apply the companion settings drafts and capture Threads > Snooze in Ember, Appearance fields, Worktrees location/prefix and Voice custom words, at 900 and 1280 px. Include raised-before versus well-after at identical scale. Check the Providers breadcrumb with a long environment label at wide and narrow widths. No paid turns; Replay only if a thread is needed.

Validation

vp run check:changed origin/maria/redesign/1-primitives-shell passed format, lint, knip, affected typechecks, five test files and React compiler checks. Runtime verification opened all twelve Thread details options, toggled one, and checked the count and Reset action. Settings consumers are verified together in the companion layers. Purely visual changes; no new tests.

CI baseline: the agent-context-budget check fails relative to main. The budget file is unchanged from this layer's base; the remaining CI checks passed when inspected.

GPT-6.1 Sol, Codex harness.

@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Nov 5, 2026
@flamboh
flamboh force-pushed the t3/redesign-fix-settings-primitives branch from e225e31 to 925f57b Compare November 5, 2026 17:36
@maria-rcks
maria-rcks force-pushed the maria/redesign/1-primitives-shell branch 2 times, most recently from a123d01 to da5b303 Compare November 6, 2026 06:16
@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:S 10-29 changed lines (additions + deletions). labels Nov 6, 2026
@flamboh
flamboh marked this pull request as ready for review November 6, 2026 06:55
@github-actions github-actions Bot added size:XXL 1,000+ changed lines (additions + deletions). size:M 30-99 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). size:XXL 1,000+ changed lines (additions + deletions). labels Nov 6, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Nov 6, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — The changes include switching the default panel-animation duration from 0 to 150 ms for clients without an explicit setting. This changes default interface motion and requires human confirmation of the intended product behavior.

Needs human approval because:

  • Per-review cost limit exceeded (workspace setting). Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings, or comment @macroscope-app review this PR to bypass the limit and review now. You can add or adjust custom eligibility rules. Learn more.

@maria-rcks
maria-rcks force-pushed the maria/redesign/1-primitives-shell branch 6 times, most recently from 759da79 to 75e54f6 Compare November 9, 2026 09:10
@maria-rcks

Copy link
Copy Markdown
Collaborator

Note

Written by gpt-6.1-sol on behalf of Maria

Rebased onto L6. Kept the current settings text sizes, container-based widths, select leading icons, and snapshot sound toggle group. Applied the well surfaces and shared utility tooltip timing without replacing those newer controls.

@maria-rcks
maria-rcks force-pushed the t3/redesign-fix-settings-primitives branch from 38114bb to 3276960 Compare November 10, 2026 04:25
@maria-rcks
maria-rcks changed the base branch from maria/redesign/1-primitives-shell to maria/redesign/6-workspace-panes November 10, 2026 04:25
@macroscopeapp
macroscopeapp Bot dismissed their stale review November 10, 2026 04:25

Dismissing prior approval to re-evaluate 3276960

@macroscopeapp

macroscopeapp Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Macroscope has since reviewed this pull request. An earlier review was skipped by a cost limit; a review has now completed, so that notice no longer applies.

@github-actions github-actions Bot removed the size:M 30-99 changed lines (additions + deletions). label Nov 10, 2026
@maria-rcks
maria-rcks merged commit fa74dd1 into pingdotgg:maria/redesign/6-workspace-panes Nov 10, 2026
29 of 33 checks passed
@github-actions github-actions Bot added the size:XXL 1,000+ changed lines (additions + deletions). label Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ changed lines (additions + deletions). vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants