Skip to content

fix(web): Office previews say "1 page", "1 sheet", "1 slide" and "1 row" - #31868

Merged
Yash-Singh1 merged 1 commit into
pingdotgg:mainfrom
spoukyii:users/spoukyii/office-preview-one-page
Nov 11, 2026
Merged

Yash-Singh1 merged 1 commit into
pingdotgg:mainfrom
spoukyii:users/spoukyii/office-preview-one-page

Conversation

@spoukyii

@spoukyii spoukyii commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Office file previews use the plural for a count of one. A one-page Word document reads "1 pages", a one-sheet workbook "1 sheets", a one-slide deck "1 slides", and a one-row, one-column .ods sheet "1 rows · 1 columns". They should read "1 page", "1 sheet", "1 slide", "1 row" and "1 column".

Change

  • .docx, .xlsx and .pptx: WordDocument.tsx, Spreadsheet.tsx and Presentation.tsx in apps/web/src/components/files/office/ pass the preview header a count with a fixed plural. Each now drops the "s" when the count is one. A Word document that is still paginating keeps "1+ pages".
  • .ods: the sheet status line in apps/web/src/components/files/OfficeViewer.tsx does the same for its row and column counts. The existing .ods case in AttachmentFilePreview.browser.test.tsx opened a sheet with one row and expected 1 rows · 2 columns, so it asserted the bug. It now expects 1 row · 2 columns.

User-visible surfaces: the file preview header on web (app.t3.codes and npx t3) and desktop, which render the same components. Only these words change. Mobile does not render these previews.

Scope and approval

This is a very small fix for an obvious bug: five count words, with no behaviour change. OfficeViewer.tsx already writes its own document count this way, as `${documentCount} ${navigation}${documentCount === 1 ? "" : "s"}`. The four other counts in the Office previews were missed. It is the same singular-count defect #22926 ("1 comment", not "1 comments") and #26065 ("1 match", not "1 matches") fixed elsewhere.

The PDF viewer ("1 / 1 pages") and the SQLite viewer ("1 rows") have the same defect. They are separate previews, so this PR leaves them out.

No open PR changes these strings. #31018 edits Spreadsheet.tsx for highlight colours, and #26230 and #29051 edit the Office font files. None touches the header counts.

Verification

There is no new test, because AGENTS.md asks to leave out tests for copy text. The existing .ods case now checks the singular row count: from apps/web, vp test run --project browser src/components/files/AttachmentFilePreview.browser.test.tsx -t "preserves ods document text" passes. The screenshots below show the change.

In a running dev build (web, Windows), I added a git repository holding a one-page notes.docx, a one-sheet budget.xlsx, a one-slide kickoff.pptx and a one-cell total.ods, and opened each from Cmd/Ctrl+P. The before shots run main's copy of the changed files, and the after shots run this branch. The headers read:

main:   1 pages · Fit to width   1 sheets   1 slides · Fit to width   Sheet 1 of 1 · 1 rows · 1 columns · 2 KB
branch: 1 page · Fit to width    1 sheet    1 slide · Fit to width    Sheet 1 of 1 · 1 row · 1 column · 2 KB
Before (main) After (this branch)
Before: notes.docx header reads "1 pages" After: notes.docx header reads "1 page"
Before: budget.xlsx header reads "1 sheets" After: budget.xlsx header reads "1 sheet"
Before: kickoff.pptx header reads "1 slides" After: kickoff.pptx header reads "1 slide"
Before: total.ods status reads "1 rows · 1 columns" After: total.ods status reads "1 row · 1 column"

vp run check:changed: format, lint, knip, typecheck (2 packages) and the React compiler check pass.

Not checked: files with more than one page, sheet, slide, row or column, which keep the plural through the same expressions, and the "1+ pages" state while a long document paginates, which this fix leaves as it was.

Bug: Office file previews say "1 pages", "1 sheets" and "1 slides"

This was written with Claude Opus 5.5 in Claude Code, driven from T3 Code.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Nov 6, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 2d8b280

Macroscope's review found this PR approvable — Office previews now use singular count labels when appropriate, while preserving plural wording for incomplete page counts. The change is limited to display text and does not alter document processing or product defaults.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Office file details now use singular labels when a count is one and plural labels otherwise. Word document page details retain the loading suffix while page counts are incomplete. The ODS preview test now expects the singular row label.

Changes: Office file count labels

Layer / File(s) Summary
Count label wording
apps/web/src/components/files/OfficeViewer.tsx, apps/web/src/components/files/office/Presentation.tsx, apps/web/src/components/files/office/Spreadsheet.tsx, apps/web/src/components/files/office/WordDocument.tsx, apps/web/src/components/files/AttachmentFilePreview.browser.test.tsx
ODS row and column labels, presentation slide labels, spreadsheet sheet labels, and word document page labels now use singular wording for a count of one and plural wording otherwise. The initial page detail keeps its + suffix while loading. The ODS preview test expects “1 row · 2 columns.”

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: maria-rcks

Merge Risk: Minimal · up to e2f33

Office count labels are updated without an identified merge-blocking risk.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title clearly describes the Office preview count-label fix.
Description check Passed The description covers the problem, change, scope, approval rationale, and verification. The provided image summaries indicate that some after screenshots do not show the corrected labels; clearer scr…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description covers the problem, change, scope, approval rationale, and verification. The provided image summaries indicate that some after screenshots do not show the corrected labels; clearer screenshots would improve the evidence.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 2d8b280 and e2f33e9.

Files selected for processing: 1

  • apps/web/src/components/files/AttachmentFilePreview.browser.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

The .docx, .xlsx and .pptx previews built their header count inline with
a fixed plural, so a one-page document read "1 pages", a one-sheet
workbook "1 sheets" and a one-slide deck "1 slides". The .ods sheet
header did the same for rows and columns ("1 rows · 1 columns"). The
other office formats in OfficeViewer already drop the "s" for a count of
one.

These counts now use the same rule. A document that is still paginating
keeps "1+ pages".

Bug: Office file previews say "1 pages", "1 sheets" and "1 slides"
@spoukyii
spoukyii force-pushed the users/spoukyii/office-preview-one-page branch from 2d8b280 to e2f33e9 Compare November 6, 2026 08:57
@Yash-Singh1
Yash-Singh1 merged commit f5fe079 into pingdotgg:main Nov 11, 2026
29 of 30 checks passed
Pipyakas pushed a commit to Pipyakas/t3code that referenced this pull request Nov 11, 2026
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Nov 11, 2026
**v0.1.10-nightly.20261111.4544** · 114 changes from 29 contributors

- **Rewind without Git.** Rewind conversations in projects without a Git repository.
- **Image galleries.** Use arrow keys or preview controls to browse images viewed by an agent.
- **Composer formatting.** Wrap selected text in backticks, asterisks, or underscores to format it in the composer.
- **Quotes in messages.** See quoted passages and their comments directly in sent messages without opening a popover.
- **Long Claude sessions.** Import long Claude Code sessions that previously exceeded the transcript memory limit.
- **Faster long threads.** Open very long threads faster, with less time spent loading messages.
- **Branch switching.** Switch branches in large repositories without a short timeout interrupting checkout and leaving files partially updated.

### Plus 99 more bug fixes.

<details>
<summary>Full changelog</summary>

## What's Changed
* test(web): theme search test no longer flakes on slow runners by @t3dotgg in pingdotgg/t3code#34417
* fix(web): branch picker no longer interrupts a running turn by @ScottN-PV in pingdotgg/t3code#15255
* fix(grok): apply the selected reasoning effort to ACP sessions by @StiensWout in pingdotgg/t3code#19573
* fix(server): timed-out git commands that ignore SIGTERM no longer stall other git work by @juliusmarminge in pingdotgg/t3code#26601
* fix(desktop): Group Linux windows under the installed launcher by @mwolson in pingdotgg/t3code#10895
* fix(web): a thread started from a pull request links it by @lnieuwenhuis in pingdotgg/t3code#15848
* fix(mobile): browser address bar and Take control no longer hide under the header by @eimexdev in pingdotgg/t3code#34258
* fix(web): thread controls hide while the mobile sidebar is open by @juliusmarminge in pingdotgg/t3code#27490
* fix(web): the terminal cursor no longer leaves faint lines when it blinks off by @tiliakoos in pingdotgg/t3code#21641
* fix(shared): Claude plugin skills no longer show their name twice by @juliusmarminge in pingdotgg/t3code#26311
* fix(terminal): identify T3 Code terminal sessions by @juliusmarminge in pingdotgg/t3code#9954
* fix(git): stop new threads inheriting historical branch PRs by @juliusmarminge in pingdotgg/t3code#34218
* fix(server): t3 serve no longer offers --auto-bootstrap-project-from-cwd by @juliusmarminge in pingdotgg/t3code#34227
* fix(rewind): allow conversation-only rewind in non-git workspaces by @Revens2 in pingdotgg/t3code#18379
* fix(web): Office previews say "1 page", "1 sheet", "1 slide" and "1 row" by @spoukyii in pingdotgg/t3code#31868
* fix(chat): show late async answers in their own runs by @juliusmarminge in pingdotgg/t3code#23249
* fix(web): fix japanese text in file viewer not rendering by @Natur7a in pingdotgg/t3code#29051
* docs(mcp): t3_thread_update lists only its rename and title actions by @juliusmarminge in pingdotgg/t3code#26130
* fix(server): t3_thread_launch refuses models the provider does not advertise by @juliusmarminge in pingdotgg/t3code#26625
* fix(opencode): omit unsupported reasoning options from catalog models by @AbdulSCSkeu in pingdotgg/t3code#19000
* fix(web): long merged spreadsheet selections no longer crash by @voltcrash in pingdotgg/t3code#34331
* fix(pi): rewinding works after the Pi session was released by @juliusmarminge in pingdotgg/t3code#26322
* fix(web): Word previews no longer cut ordinary documents short by @yaacovcorcos in pingdotgg/t3code#32040
* fix(server): MCP tools reject top-level arguments they do not declare by @juliusmarminge in pingdotgg/t3code#26721
* fix(server): slow title generations no longer hold every effect worker by @juliusmarminge in pingdotgg/t3code#26272
* fix(cursor): Cursor no longer adds attribution when cli-config turns it off by @juliusmarminge in pingdotgg/t3code#26908
* fix(server): listing linked environments no longer waits out an asleep peer by @juliusmarminge in pingdotgg/t3code#28543
* fix(server): Git failures no longer record checkpoints as missing by @juliusmarminge in pingdotgg/t3code#28957
* fix(provider-acp-registry): prepared binary agents stay ready when the registry advances by @juliusmarminge in pingdotgg/t3code#26543
* fix(desktop): annotation tool keys work after clicking a toolbar button by @juliusmarminge in pingdotgg/t3code#26211
* fix(server): PR sync stops reading missing pull requests every minute by @abiassi in pingdotgg/t3code#17800
* fix(server): failed provider updates show the updater's error, not its closing hint by @juliusmarminge in pingdotgg/t3code#26298
* fix(server): a busy embedded frame no longer holds copy keys back by @juliusmarminge in pingdotgg/t3code#34204
* fix(clients): collapsed turns show one context-compacted divider by @binjamshid in pingdotgg/t3code#34177
* fix(mobile): un-settle while a settle is pending is no longer ignored by @juliusmarminge in pingdotgg/t3code#26578
* fix(ssh): reconnect and disconnect ignore a remote pid file that no longer names the server by @juliusmarminge in pingdotgg/t3code#26963
* fix(server): device setup names a missing npm instead of a generic failure by @juliusmarminge in pingdotgg/t3code#28258
* fix(web): render citation chips in the collapsed composer by @EtanHey in pingdotgg/t3code#22148
* fix(server): agents settle this thread when asked by @juliusmarminge in pingdotgg/t3code#26765
* fix(web): copying commands with prose no longer adds code fences by @juliusmarminge in pingdotgg/t3code#24433
* fix(server): Claude effort picker marks levels capped by maxEffortLevel by @juliusmarminge in pingdotgg/t3code#23629
* fix(web): start clone when destination is picked in file manager by @macodev00 in pingdotgg/t3code#22226
* fix(web): expanding a diff whose files changed no longer crashes by @juliusmarminge in pingdotgg/t3code#28056
* fix(server): a steer during a delegate_task wait no longer drops the child's result by @juliusmarminge in pingdotgg/t3code#27387
* fix(server): subagent threads settle with their parent instead of sweeping on their own by @mikeohuo in pingdotgg/t3code#19665
* fix(client-runtime): reopening a folder picker refreshes its listing by @juliusmarminge in pingdotgg/t3code#23289
* fix(chat): keep scratch file links usable by @voltcrash in pingdotgg/t3code#30768
* fix(server): text generation falls back to an enabled custom instance instead of a disabled default by @juliusmarminge in pingdotgg/t3code#28918
* fix(server): peer link migrations 71 and 72 rerun safely by @juliusmarminge in pingdotgg/t3code#26834
* fix(ssh): explain how to recover from failed host key checks by @juliusmarminge in pingdotgg/t3code#23785
* fix(server): show when a Claude steer is waiting for acceptance by @juliusmarminge in pingdotgg/t3code#24785
* fix(web): keep grouped project icons consistent in settings by @hpflatorre in pingdotgg/t3code#14493
* fix(server): update branch labels after terminal checkouts by @juliusmarminge in pingdotgg/t3code#23422
* fix(web): track switch dialog no longer offers a switch that moves nothing by @juliusmarminge in pingdotgg/t3code#27484
* fix(shared): a zero-credit cap no longer marks seat-based Codex out of usage by @juliusmarminge in pingdotgg/t3code#34243
* fix(web): screen readers can browse and Tab through the settings sections again by @juliusmarminge in pingdotgg/t3code#30841
* fix(server): Codex forks no longer request full turn history by @juliusmarminge in pingdotgg/t3code#24537
* fix(web): keep model favorites usable after disabling a provider by @juliusmarminge in pingdotgg/t3code#23479
* fix(server): workspace search no longer indexes the home directory by @juliusmarminge in pingdotgg/t3code#26126
* fix(claude): a killed Claude process names its signal on the failed turn by @juliusmarminge in pingdotgg/t3code#26086
* fix(server): t3 service install works on Linux hosts without a login session by @juliusmarminge in pingdotgg/t3code#29923
* fix(server): Copilot threads load optional T3 tools on demand by @juliusmarminge in pingdotgg/t3code#34245
* fix(server): runtime prune no longer keeps a version whose directory is on the service PATH by @juliusmarminge in pingdotgg/t3code#25870
* fix(server): branch switch no longer kills a slow git checkout by @juliusmarminge in pingdotgg/t3code#23539
* fix(server): fail Codex turns stuck in a provider retry by @maria-rcks in pingdotgg/t3code#33130
* fix(server,desktop): browser tools report why a page failed to load by @robertnisipeanu in pingdotgg/t3code#18588
* fix(server): show a context handoff when a provider conversation can't be resumed by @juliusmarminge in pingdotgg/t3code#28195
* fix(server): Claude --settings and prompt-file launch args expand ~ by @juliusmarminge in pingdotgg/t3code#26649
* fix(server): a Claude thread waiting on a ScheduleWakeup stays in Working by @juliusmarminge in pingdotgg/t3code#23648
* fix(server): usage prices long-context requests at above-tier rates by @juliusmarminge in pingdotgg/t3code#25430
* fix(server): Simlock open failures show what agent-device reported by @juliusmarminge in pingdotgg/t3code#27564
* fix(clients): show the right app name and thread context by @chasemakes in pingdotgg/t3code#18442
* fix(server): long Claude sessions import instead of being skipped by @juliusmarminge in pingdotgg/t3code#29183
* fix(server): closed PR watches end even when the activity read fails by @juliusmarminge in pingdotgg/t3code#27953
* fix(desktop): a hidden preview tab no longer keeps the display awake after a screenshot by @juliusmarminge in pingdotgg/t3code#25978
* fix(server): successful worktree handoffs complete normally by @juliusmarminge in pingdotgg/t3code#24545
* fix(mobile): swipe action labels stay whole at larger Android text sizes by @juliusmarminge in pingdotgg/t3code#27335
* fix(server): opening a pull request loads while its host is rate-limited by @juliusmarminge in pingdotgg/t3code#27595
* fix(server): Codex turns that auto-compact end instead of looping on restored context by @juliusmarminge in pingdotgg/t3code#25911
* fix(server): keep queued Claude workflow members pending by @juliusmarminge in pingdotgg/t3code#25325
* fix(server): t3 doctor warns how long reclaiming takes and shows each step by @juliusmarminge in pingdotgg/t3code#29956
* fix(server): recover service PATH after a slow login shell probe by @juliusmarminge in pingdotgg/t3code#23356
* fix(server): say Git isn't installed when a new project can't run git by @juliusmarminge in pingdotgg/t3code#28219
* fix(server): agent clones are no longer cut off after 2 minutes by @juliusmarminge in pingdotgg/t3code#27588
* feat(web): a quote in a sent message shows as an inset card by @maria-rcks in pingdotgg/t3code#34181
* perf(server): very long threads open about 10x faster by @t3dotgg in pingdotgg/t3code#34490
* fix(web): improve Excel spreadsheet previews by @Yash-Singh1 in pingdotgg/t3code#34429
* fix(server): pass the process runner to the systemd unit directory read in bootServiceUnitPath by @juliusmarminge in pingdotgg/t3code#34518
* fix(mobile): sidebar empty states and repeated usage notices by @maria-rcks in pingdotgg/t3code#33188
* ci: stop uploading per-shard test cache reports by @juliusmarminge in pingdotgg/t3code#34525
* refactor(mobile): lists use LegendList, FlatList is a restricted import by @juliusmarminge in pingdotgg/t3code#34513
* fix(chat): keep final replies visible after steering by @Yash-Singh1 in pingdotgg/t3code#34501
* fix(server): fail any provider turn stuck in a retry by @maria-rcks in pingdotgg/t3code#33152
* fix(server): migrate compatible legacy service install state by @Exotic209093 in pingdotgg/t3code#19449
* docs(orchestration-v2): task_cancel describes queued-only tasks and when it rejects by @juliusmarminge in pingdotgg/t3code#34517
* fix(server): stop a Codex app-server that ignores SIGTERM by @yaacovcorcos in pingdotgg/t3code#34461
* fix(server): branch totals stop relisting untracked files after a failed listing by @yaacovcorcos in pingdotgg/t3code#34460
* test(server): wire budget covers stale todo lists in long threads by @t3dotgg in pingdotgg/t3code#34522
* fix(server): reject worktree launches in non-Git projects by @voltcrash in pingdotgg/t3code#34279
* fix(web): opening a file focuses its editor so Cmd+F searches it by @armanarutiunov in pingdotgg/t3code#34360
* fix(mobile): stale Claude threads show a compact-before-send notice by @praffiii in pingdotgg/t3code#34263
* fix(cursor): retry a timed-out catalog read before reporting an error by @juliusmarminge in pingdotgg/t3code#34553
* fix(web): wrapping a selection in backticks formats it as code by @SepehrRajabi in pingdotgg/t3code#14870
* fix(web): arrow keys and buttons step through the images an agent viewed by @t3dotgg in pingdotgg/t3code#34333
* fix(web): draw rounded powerline caps to fill the terminal cell by @joaomdsferro in pingdotgg/t3code#34552
* fix(web): "Show full message" only appears when it at least doubles the message by @t3dotgg in pingdotgg/t3code#34306
* fix(server): show when Stop leaves a Claude steer unconfirmed by @juliusmarminge in pingdotgg/t3code#23807
* ci: split web tests over two runners so every run finishes sooner by @juliusmarminge in pingdotgg/t3code#34554
* fix(web): keep background toast Open button inline by @Yash-Singh1 in pingdotgg/t3code#34572
* fix(server): Claude effort changes apply to the running turn by @juliusmarminge in pingdotgg/t3code#34563
* fix(web): keep wide terminal glyphs on the cell grid by @juliusmarminge in pingdotgg/t3code#27948
* test(web): check custom worksheet targets at the preparation layer by @juliusmarminge in pingdotgg/t3code#34586
* fix(web): improve PowerPoint slide font rendering by @Yash-Singh1 in pingdotgg/t3code#34453
* fix(server): worktree launches refuse branch names an existing branch blocks by @juliusmarminge in pingdotgg/t3code#29328

## New Contributors
* @Revens2 made their first contribution in pingdotgg/t3code#18379
* @Natur7a made their first contribution in pingdotgg/t3code#29051
* @AbdulSCSkeu made their first contribution in pingdotgg/t3code#19000
* @abiassi made their first contribution in pingdotgg/t3code#17800
* @mikeohuo made their first contribution in pingdotgg/t3code#19665
* @hpflatorre made their first contribution in pingdotgg/t3code#14493
* @chasemakes made their first contribution in pingdotgg/t3code#18442
* @praffiii made their first contribution in pingdotgg/t3code#34263
* @SepehrRajabi made their first contribution in pingdotgg/t3code#14870
* @joaomdsferro made their first contribution in pingdotgg/t3code#34552

**Full Changelog**: pingdotgg/t3code@v0.1.10-nightly.20261111.4529...v0.1.10-nightly.20261111.4544

</details>


Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.10-nightly.20261111.4544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants