Skip to content

fix(server): retain Codex model metadata when catalog discovery fails #31903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sasoder wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(server): retain Codex model metadata when catalog discovery fails #31903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/server/src/provider/CodexManagedRuntime.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ it.live.each(
arg.startsWith("model_providers.openai_token_sharing="),
)!;
assert.include(provider, 'base_url="https://api.openai.com/v1"');
assert.include(provider, 'model_catalog_url="https://api.openai.com/v1/models"');
assert.notInclude(provider, "model_catalog_url");
assert.notInclude(provider, "env_key");
assert.include(provider, "refresh_interval_ms=0");
// regression: #16132 Codex fetches each token through this helper, so a running
Expand Down
3 changes: 2 additions & 1 deletion apps/server/src/provider/CodexManagedRuntime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ const managedCodexLaunchArgs = (command: string, args: ReadonlyArray<string>) =>
[
'model_provider="openai_token_sharing"',
// Codex persists this provider ID in rollouts and needs it unchanged to resume.
`model_providers.openai_token_sharing={name="OpenAI Token Sharing",base_url="https://api.openai.com/v1",model_catalog_url="https://api.openai.com/v1/models",wire_api="responses",requires_openai_auth=false,supports_websockets=false,auth={command=${JSON.stringify(command)},args=${JSON.stringify(args)},timeout_ms=${COMMAND_TIMEOUT_MS},refresh_interval_ms=0}}`,
// An explicit catalog URL disables bundled metadata fallback when discovery fails.
`model_providers.openai_token_sharing={name="OpenAI Token Sharing",base_url="https://api.openai.com/v1",wire_api="responses",requires_openai_auth=false,supports_websockets=false,auth={command=${JSON.stringify(command)},args=${JSON.stringify(args)},timeout_ms=${COMMAND_TIMEOUT_MS},refresh_interval_ms=0}}`,
"features.api_key_model_discovery=true",
"features.multi_agent=false",
"features.multi_agent_v2=false",
Expand Down
Loading